[binutils-gdb] Make regcache_cpy_no_passthrough static

[Jan Kratochvil <jkratoch at sourceware dot org>]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=bd49952bd7fbe616e2cb488e8080502f2338aaa2

commit bd49952bd7fbe616e2cb488e8080502f2338aaa2
Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Date:   Wed May 13 20:47:33 2015 +0200

    Make regcache_cpy_no_passthrough static
    
    regcache_cpy_no_passthrough is no longer used for a standalone call.
    
    gdb/ChangeLog
    2015-05-13  Jan Kratochvil  <jan.kratochvil@redhat.com>
    
    	* regcache.c (regcache_cpy_no_passthrough): New declaration.
    	(regcache_cpy_no_passthrough): Make it static, add function comment.
    	* regcache.h (regcache_dup, regcache_cpy): Reduce/update their comment.
    	(regcache_cpy_no_passthrough): Remove declaration.

Diff:
---
 gdb/ChangeLog  |  7 +++++++
 gdb/regcache.c | 10 +++++++++-
 gdb/regcache.h |  9 ++-------
 3 files changed, 18 insertions(+), 8 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0b38622..6cb033b 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,12 @@
 2015-05-13  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
+	* regcache.c (regcache_cpy_no_passthrough): New declaration.
+	(regcache_cpy_no_passthrough): Make it static, add function comment.
+	* regcache.h (regcache_dup, regcache_cpy): Reduce/update their comment.
+	(regcache_cpy_no_passthrough): Remove declaration.
+
+2015-05-13  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
 	* gdbthread.h (struct thread_control_state): Update comment for
 	proceed_to_finish.
 	* infcall.c (run_inferior_call): Update comment about
diff --git a/gdb/regcache.c b/gdb/regcache.c
index 366eba0..86e648a 100644
--- a/gdb/regcache.c
+++ b/gdb/regcache.c
@@ -391,6 +391,9 @@ do_cooked_read (void *src, int regnum, gdb_byte *buf)
   return regcache_cooked_read (regcache, regnum, buf);
 }
 
+static void regcache_cpy_no_passthrough (struct regcache *dst,
+					 struct regcache *src);
+
 void
 regcache_cpy (struct regcache *dst, struct regcache *src)
 {
@@ -407,7 +410,12 @@ regcache_cpy (struct regcache *dst, struct regcache *src)
     regcache_cpy_no_passthrough (dst, src);
 }
 
-void
+/* Copy/duplicate the contents of a register cache.  Unlike regcache_cpy,
+   which is pass-through, this does not go through to the target.
+   Only values values already in the cache are transferred.  The SRC and DST
+   buffers must not overlap.  */
+
+static void
 regcache_cpy_no_passthrough (struct regcache *dst, struct regcache *src)
 {
   gdb_assert (src != NULL && dst != NULL);
diff --git a/gdb/regcache.h b/gdb/regcache.h
index 394506a..a9fb44b 100644
--- a/gdb/regcache.h
+++ b/gdb/regcache.h
@@ -224,17 +224,12 @@ extern void regcache_save (struct regcache *dst,
 
 /* Copy/duplicate the contents of a register cache.  By default, the
    operation is pass-through.  Writes to DST and reads from SRC will
-   go through to the target.
+   go through to the target.  See also regcache_cpy_no_passthrough.
 
-   The ``cpy'' functions can not have overlapping SRC and DST buffers.
-
-   ``no passthrough'' versions do not go through to the target.  They
-   only transfer values already in the cache.  */
+   regcache_cpy can not have overlapping SRC and DST buffers.  */
 
 extern struct regcache *regcache_dup (struct regcache *regcache);
 extern void regcache_cpy (struct regcache *dest, struct regcache *src);
-extern void regcache_cpy_no_passthrough (struct regcache *dest,
-					 struct regcache *src);
 
 extern void registers_changed (void);
 extern void registers_changed_ptid (ptid_t);