[binutils-gdb] Add "set remote multiprocess-extensions-packet" command

[Pedro Alves <palves at sourceware dot org>]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=73b8c1fda9f3759874a9a1a7e7402276da057153

commit 73b8c1fda9f3759874a9a1a7e7402276da057153
Author: Pedro Alves <palves@redhat.com>
Date:   Mon Aug 24 19:58:31 2015 +0100

    Add "set remote multiprocess-extensions-packet" command
    
    Being able to force-disable the RSP multiprocess extensions is useful
    for testing.
    
    gdb/ChangeLog:
    2015-08-24  Pedro Alves  <palves@redhat.com>
    
    	* NEWS (New commands): Mention set/show remote
    	multiprocess-extensions-packet.
    	* remote.c (remote_query_supported): Only tell the server to use
    	the multiprocess extensions if the user hasn't force-disabled them
    	with "set remote multiprocess-extensions-packet off".
    
    gdb/doc/ChangeLog:
    2015-08-24  Pedro Alves  <palves@redhat.com>
    
    	* gdb.texinfo (Remote Configuration): Document the "set/show
    	remote multiprocess-extensions-packet" commands.

Diff:
---
 gdb/ChangeLog       | 8 ++++++++
 gdb/NEWS            | 4 ++++
 gdb/doc/ChangeLog   | 5 +++++
 gdb/doc/gdb.texinfo | 4 ++++
 gdb/remote.c        | 7 +++++--
 5 files changed, 26 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ac65a21..7ffc61b 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,13 @@
 2015-08-24  Pedro Alves  <palves@redhat.com>
 
+	* NEWS (New commands): Mention set/show remote
+	multiprocess-extensions-packet.
+	* remote.c (remote_query_supported): Only tell the server to use
+	the multiprocess extensions if the user hasn't force-disabled them
+	with "set remote multiprocess-extensions-packet off".
+
+2015-08-24  Pedro Alves  <palves@redhat.com>
+
 	* gnulib/update-gnulib.sh (GNULIB_COMMIT_SHA1): Set to
 	1029a8112290f6eee9d7878a391c49db42c999bd.
 	* gnulib/configure, gnulib/config.in, gnulib/aclocal.m4:
diff --git a/gdb/NEWS b/gdb/NEWS
index 9edfd5e..49c4a11 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -28,6 +28,10 @@ set debug bfd-cache
 show debug bfd-cache
   Control display of debugging info regarding bfd caching.
 
+set remote multiprocess-extensions-packet
+show remote multiprocess-extensions-packet
+  Set/show the use of the remote protocol multiprocess extensions.
+
 * The "disassemble" command accepts a new modifier: /s.
   It prints mixed source+disassembly like /m with two differences:
   - disassembled instructions are now printed in program order, and
diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index 2fc5fd0..29c66b8 100644
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,5 +1,10 @@
 2015-08-24  Pedro Alves  <palves@redhat.com>
 
+	* gdb.texinfo (Remote Configuration): Document the "set/show
+	remote multiprocess-extensions-packet" commands.
+
+2015-08-24  Pedro Alves  <palves@redhat.com>
+
 	* gdb.texinfo (Embedded Processors) <ARM>: Remove references to RDI.
 	<M32R>: Remove references to M32R/D.
 	<M68K>: Remove references to target dbug.
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 5dfb14b..cd0abad 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -20205,6 +20205,10 @@ are:
 @tab @code{Z0 and Z1}
 @tab @code{Support for target-side breakpoint condition evaluation}
 
+@item @code{multiprocess-extensions}
+@tab @code{multiprocess extensions}
+@tab Debug multiple processes and remote process PID awareness
+
 @item @code{swbreak-feature}
 @tab @code{swbreak stop reason}
 @tab @code{break}
diff --git a/gdb/remote.c b/gdb/remote.c
index 48a4f7d..f2968eb 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -4352,7 +4352,8 @@ remote_query_supported (void)
       char *q = NULL;
       struct cleanup *old_chain = make_cleanup (free_current_contents, &q);
 
-      q = remote_query_supported_append (q, "multiprocess+");
+      if (packet_set_cmd_state (PACKET_multiprocess_feature) != AUTO_BOOLEAN_FALSE)
+	q = remote_query_supported_append (q, "multiprocess+");
 
       if (packet_set_cmd_state (PACKET_swbreak_feature) != AUTO_BOOLEAN_FALSE)
 	q = remote_query_supported_append (q, "swbreak+");
@@ -13231,6 +13232,9 @@ Show the maximum size of the address (in bits) in a memory packet."), NULL,
   add_packet_config_cmd (&remote_protocol_packets[PACKET_Qbtrace_conf_bts_size],
        "Qbtrace-conf:bts:size", "btrace-conf-bts-size", 0);
 
+  add_packet_config_cmd (&remote_protocol_packets[PACKET_multiprocess_feature],
+       "multiprocess-feature", "multiprocess-feature", 0);
+
   add_packet_config_cmd (&remote_protocol_packets[PACKET_swbreak_feature],
                          "swbreak-feature", "swbreak-feature", 0);
 
@@ -13260,7 +13264,6 @@ Show the maximum size of the address (in bits) in a memory packet."), NULL,
 	switch (i)
 	  {
 	  case PACKET_QNonStop:
-	  case PACKET_multiprocess_feature:
 	  case PACKET_EnableDisableTracepoints_feature:
 	  case PACKET_tracenz_feature:
 	  case PACKET_DisconnectedTracing_feature: