This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] gdb/cli: Remove casts of NULL during assignment.


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b03e6ad9cd2064214c0fbff179c7e47c855315e3

commit b03e6ad9cd2064214c0fbff179c7e47c855315e3
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Date:   Mon Aug 31 21:25:37 2015 +0100

    gdb/cli: Remove casts of NULL during assignment.
    
    In the following code:
    
        struct symbol *wsym = (struct symbol *) NULL;
    
    the cast of NULL is redundant, it adds noise, and is just one more thing
    to change if the type of wsym ever changes.  There are a relatively
    small number of places in gdb where the above code pattern is used.
    Usually the cast is removed like this:
    
        struct symbol *wsym = NULL;
    
    This commit updates all the places within the gdb/cli directory where we
    cast NULL during assignment, removing the cast.
    
    gdb/ChangeLog:
    
    	* cli/cli-decode.c (find_cmd): Remove cast of NULL pointer.

Diff:
---
 gdb/ChangeLog        | 4 ++++
 gdb/cli/cli-decode.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 2ae453f..fdf2cd1 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
 2015-09-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 
+	* cli/cli-decode.c (find_cmd): Remove cast of NULL pointer.
+
+2015-09-04  Andrew Burgess  <andrew.burgess@embecosm.com>
+
 	* c-valprint.c (print_unpacked_pointer): Remove cast of NULL
 	pointer.
 	* dbxread.c (dbx_end_psymtab): Likewise.
diff --git a/gdb/cli/cli-decode.c b/gdb/cli/cli-decode.c
index f5b6fc4..cab2336 100644
--- a/gdb/cli/cli-decode.c
+++ b/gdb/cli/cli-decode.c
@@ -1219,7 +1219,7 @@ find_cmd (const char *command, int len, struct cmd_list_element *clist,
 {
   struct cmd_list_element *found, *c;
 
-  found = (struct cmd_list_element *) NULL;
+  found = NULL;
   *nfound = 0;
   for (c = clist; c; c = c->next)
     if (!strncmp (command, c->name, len)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]