This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Use value_contents instead of value_contents_writeable
- From: Yao Qi <qiyao at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 16 Nov 2015 14:48:25 -0000
- Subject: [binutils-gdb] Use value_contents instead of value_contents_writeable
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0d1993c072e5617b69204aef641acd2385b080ec
commit 0d1993c072e5617b69204aef641acd2385b080ec
Author: Yao Qi <yao.qi@linaro.org>
Date: Mon Nov 16 14:47:50 2015 +0000
Use value_contents instead of value_contents_writeable
Both aarch64_push_dummy_call and bfin_push_dummy_call only use args[i]
contents but then never write to them, so that we can use
value_contents instead.
gdb:
2015-11-16 Yao Qi <yao.qi@linaro.org>
* aarch64-tdep.c (aarch64_push_dummy_call): Call value_contents instead
of value_contents_writeable.
* bfin-tdep.c (bfin_push_dummy_call): Likewise.
Diff:
---
gdb/ChangeLog | 6 ++++++
gdb/aarch64-tdep.c | 2 +-
gdb/bfin-tdep.c | 2 +-
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 2b2409a..b445cec 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
2015-11-16 Yao Qi <yao.qi@linaro.org>
+ * aarch64-tdep.c (aarch64_push_dummy_call): Call value_contents
+ instead of value_contents_writeable.
+ * bfin-tdep.c (bfin_push_dummy_call): Likewise.
+
+2015-11-16 Yao Qi <yao.qi@linaro.org>
+
* arm-tdep.c (arm_push_dummy_call): New array buf. Store regval
to buf. Pass buf instead of val to push_stack_item.
diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index bc282e9..553a420 100644
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -1300,7 +1300,7 @@ aarch64_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
check_typedef (value_type (field));
pass_in_v_or_stack (gdbarch, regcache, &info, field_type,
- value_contents_writeable (field));
+ value_contents (field));
}
}
else
diff --git a/gdb/bfin-tdep.c b/gdb/bfin-tdep.c
index 1d48225..54936cc 100644
--- a/gdb/bfin-tdep.c
+++ b/gdb/bfin-tdep.c
@@ -531,7 +531,7 @@ bfin_push_dummy_call (struct gdbarch *gdbarch,
int container_len = (TYPE_LENGTH (value_type) + 3) & ~3;
sp -= container_len;
- write_memory (sp, value_contents_writeable (args[i]), container_len);
+ write_memory (sp, value_contents (args[i]), container_len);
}
/* Initialize R0, R1, and R2 to the first 3 words of parameters. */