This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Constify value_string


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7cc3f8e23b5c19a50722adefce986230b191e9cd

commit 7cc3f8e23b5c19a50722adefce986230b191e9cd
Author: Simon Marchi <simon.marchi@ericsson.com>
Date:   Wed Nov 18 11:20:22 2015 -0500

    Constify value_string
    
    If we constify value_cstring, we might as well constify this one.
    
    gdb/ChangeLog:
    
    	* valops.c (value_string): Constify 'ptr' parameter.
    	* value.h (value_string): Constify 'ptr' parameter.

Diff:
---
 gdb/ChangeLog | 5 +++++
 gdb/valops.c  | 2 +-
 gdb/value.h   | 2 +-
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d92ba43..d1b40b8 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,4 +1,9 @@
 2015-11-18  Simon Marchi  <simon.marchi@ericsson.com>
+
+	* valops.c (value_string): Constify 'ptr' parameter.
+	* value.h (value_string): Constify 'ptr' parameter.
+
+2015-11-18  Simon Marchi  <simon.marchi@ericsson.com>
 	    Pedro Alves  <palves@redhat.com>
 
 	* break-catch-sig.c (signal_catchpoint_print_one): Add cast.
diff --git a/gdb/valops.c b/gdb/valops.c
index 67e6afe..5e5f685 100644
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -1649,7 +1649,7 @@ value_cstring (const char *ptr, ssize_t len, struct type *char_type)
    string may contain embedded null bytes.  */
 
 struct value *
-value_string (char *ptr, ssize_t len, struct type *char_type)
+value_string (const char *ptr, ssize_t len, struct type *char_type)
 {
   struct value *val;
   int lowbound = current_language->string_lower_bound;
diff --git a/gdb/value.h b/gdb/value.h
index 94a2234..eea0e59 100644
--- a/gdb/value.h
+++ b/gdb/value.h
@@ -698,7 +698,7 @@ extern void value_free_to_mark (struct value *mark);
 
 extern struct value *value_cstring (const char *ptr, ssize_t len,
 				    struct type *char_type);
-extern struct value *value_string (char *ptr, ssize_t len,
+extern struct value *value_string (const char *ptr, ssize_t len,
 				   struct type *char_type);
 
 extern struct value *value_array (int lowbound, int highbound,


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]