This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Use a separate variable for the size passed to sysctl.
- From: John Baldwin <jhb at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 19 Jan 2016 23:29:45 -0000
- Subject: [binutils-gdb] Use a separate variable for the size passed to sysctl.
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f2feec9809edbeeee0bb5b036e4ae25f9c37cd14
commit f2feec9809edbeeee0bb5b036e4ae25f9c37cd14
Author: John Baldwin <jhb@FreeBSD.org>
Date: Tue Jan 19 10:23:00 2016 -0800
Use a separate variable for the size passed to sysctl.
This fixes a sign mismatch warning.
gdb/ChangeLog:
* fbsd-nat.c (fbsd_pid_to_exec_file): Use new "buflen" instead of
"len" with sysctl.
Diff:
---
gdb/ChangeLog | 5 +++++
gdb/fbsd-nat.c | 6 ++++--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e8277f3..6a77fdd 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2016-01-19 John Baldwin <jhb@FreeBSD.org>
+ * fbsd-nat.c (fbsd_pid_to_exec_file): Use new "buflen" instead of
+ "len" with sysctl.
+
+2016-01-19 John Baldwin <jhb@FreeBSD.org>
+
* fbsd-tdep.c (find_stop_signal): Remove.
(struct fbsd_collect_regset_section_cb) <lwp>: New field.
<stop_signal>: New field.
diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c
index d2ec527..e7ca0e6 100644
--- a/gdb/fbsd-nat.c
+++ b/gdb/fbsd-nat.c
@@ -43,18 +43,20 @@
static char *
fbsd_pid_to_exec_file (struct target_ops *self, int pid)
{
- ssize_t len = PATH_MAX;
+ ssize_t len;
static char buf[PATH_MAX];
char name[PATH_MAX];
#ifdef KERN_PROC_PATHNAME
+ size_t buflen;
int mib[4];
mib[0] = CTL_KERN;
mib[1] = KERN_PROC;
mib[2] = KERN_PROC_PATHNAME;
mib[3] = pid;
- if (sysctl (mib, 4, buf, &len, NULL, 0) == 0)
+ buflen = sizeof buf;
+ if (sysctl (mib, 4, buf, &buflen, NULL, 0) == 0)
return buf;
#endif