This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] PR symtab/20652 - fix psymbol_compare


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3e611445bf05fa20e0befa41afa42651d1983734

commit 3e611445bf05fa20e0befa41afa42651d1983734
Author: Tom Tromey <tom@tromey.com>
Date:   Fri Sep 30 15:42:28 2016 -0600

    PR symtab/20652 - fix psymbol_compare
    
    This fixes an oversight in psymbol_compare.
    
    2016-10-05  Tom Tromey  <tom@tromey.com>
    
    	PR symtab/20652:
    	* psymtab.c (psymbol_compare): Correctly compare "ginfo.value"
    	fields.

Diff:
---
 gdb/ChangeLog | 6 ++++++
 gdb/psymtab.c | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e2b5c2b..1fc318e 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2016-10-05  Tom Tromey  <tom@tromey.com>
+
+	PR symtab/20652:
+	* psymtab.c (psymbol_compare): Correctly compare "ginfo.value"
+	fields.
+
 2016-10-05  Andreas Arnez  <arnez@linux.vnet.ibm.com>
 
 	* dwarf2expr.c (dwarf_expr_require_composition): Allow
diff --git a/gdb/psymtab.c b/gdb/psymtab.c
index a39c6e2..edcaa8b 100644
--- a/gdb/psymtab.c
+++ b/gdb/psymtab.c
@@ -1577,7 +1577,7 @@ psymbol_compare (const void *addr1, const void *addr2, int length)
   struct partial_symbol *sym1 = (struct partial_symbol *) addr1;
   struct partial_symbol *sym2 = (struct partial_symbol *) addr2;
 
-  return (memcmp (&sym1->ginfo.value, &sym1->ginfo.value,
+  return (memcmp (&sym1->ginfo.value, &sym2->ginfo.value,
                   sizeof (sym1->ginfo.value)) == 0
 	  && sym1->ginfo.language == sym2->ginfo.language
           && PSYMBOL_DOMAIN (sym1) == PSYMBOL_DOMAIN (sym2)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]