This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb/gdb-7.12-branch] stack: fix gdb.dwarf2/dw2-undefined-ret-addr.exp regression


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3929b7e909b48a20d5dac6631e519f3b6b2ac84e

commit 3929b7e909b48a20d5dac6631e519f3b6b2ac84e
Author: Markus Metzger <markus.t.metzger@intel.com>
Date:   Fri Jul 22 10:01:19 2016 +0200

    stack: fix gdb.dwarf2/dw2-undefined-ret-addr.exp regression
    
    Commit a038fa3e14a4 stack: check frame_unwind_caller_id adds a frame_id check to
    frame_info and treats a missing frame_id as NOT_AVAILABLE_ERROR.  This causes a
    regression in gdb.dwarf2/dw2-undefined-ret-addr.exp.
    
    Treat a missing frame_id as OPTIMIZED_OUT_ERROR instead.
    
    See also https://sourceware.org/ml/gdb-patches/2016-07/msg00273.html.

Diff:
---
 gdb/ChangeLog | 5 +++++
 gdb/stack.c   | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index fa491f0..ea8fdd1 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2016-10-06  Markus Metzger  <markus.t.metzger@intel.com>
+
+	* stack.c (frame_info): Call val_print_not_saved instead of
+	val_print_unavailable if frame_id check fails.
+
 2016-10-06  Pedro Alves  <palves@redhat.com>
 
 	* jit.c (free_objfile_data): Delete the JIT breakpoint and clear
diff --git a/gdb/stack.c b/gdb/stack.c
index 3ce3138..c77bfc0 100644
--- a/gdb/stack.c
+++ b/gdb/stack.c
@@ -1531,7 +1531,7 @@ frame_info (char *addr_exp, int from_tty)
   printf_filtered ("saved %s = ", pc_regname);
 
   if (!frame_id_p (frame_unwind_caller_id (fi)))
-    val_print_unavailable (gdb_stdout);
+    val_print_not_saved (gdb_stdout);
   else
     {
       TRY


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]