[binutils-gdb] gdb: Disable -Werror for -Wmaybe-uninitialized

[Pedro Alves <palves at sourceware dot org>]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e13cb306f099a8cd450c9fba0dfa22521aaa3c95

commit e13cb306f099a8cd450c9fba0dfa22521aaa3c95
Author: Pedro Alves <palves@redhat.com>
Date:   Fri May 5 01:03:28 2017 +0100

    gdb: Disable -Werror for -Wmaybe-uninitialized
    
    Newer GCCs are triggering false-positive -Wmaybe-uninitialized
    warnings around code that uses gdb::optional:
      https://sourceware.org/ml/gdb-patches/2017-05/msg00118.html
    
    Using std::optional wouldn't help, it triggers the same warnings:
      https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80635
    
    Initializing the variables to quiet the warning would defeat the
    purpose of gdb::optional.  Making the optional ctor memset its storage
    would be a pessimization.  Wrapping gdb::optional's internals with
    "#pragma GCC diagnostic push/ignored/pop" doesn't work, we'd have to
    wrap uses of gdb::optional instead, which I think would get unwieldy
    and ugly as we start using gdb::optional more and more.
    
    The -Wmaybe-uninitialized warning is documented as producing false
    positives (unlike -Wuninialized), so until we find a better
    workaround, disable -Werror for this warning.  You'll still see the
    warning when building gdb, but it won't cause a build failure.
    
    Tested by building with gcc 4.8.5, 5.3.1, and gcc trunk (20170428).
    
    gdb/ChangeLog:
    2017-05-05  Pedro Alves  <palves@redhat.com>
    
    	* warning.m4 (build_warnings): Add -Wno-error=maybe-uninitialized.
    	* configure: Regenerate.
    
    gdb/gdbserver/ChangeLog:
    2017-05-05  Pedro Alves  <palves@redhat.com>
    
    	* configure: Regenerate.

Diff:
---
 gdb/ChangeLog           | 5 +++++
 gdb/configure           | 2 +-
 gdb/gdbserver/ChangeLog | 4 ++++
 gdb/gdbserver/configure | 2 +-
 gdb/warning.m4          | 2 +-
 5 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 6e3a51e..475091d 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2017-05-05  Pedro Alves  <palves@redhat.com>
+
+	* warning.m4 (build_warnings): Add -Wno-error=maybe-uninitialized.
+	* configure: Regenerate.
+
 2017-05-04  Pedro Alves  <palves@redhat.com>
 
 	* Makefile.in (SFILES): Add progspace-and-thread.c.
diff --git a/gdb/configure b/gdb/configure
index 25895b1..1554667 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -15108,7 +15108,7 @@ build_warnings="-Wall -Wpointer-arith \
 -Wno-unused -Wunused-value -Wunused-function \
 -Wno-switch -Wno-char-subscripts \
 -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable \
--Wno-sign-compare -Wno-narrowing"
+-Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized"
 
 # Enable -Wno-format by default when using gcc on mingw since many
 # GCC versions complain about %I64.
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index 8f7848c..e09035c 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,7 @@
+2017-05-05  Pedro Alves  <palves@redhat.com>
+
+	* configure: Regenerate.
+
 2017-05-03  Sergio Durigan Junior  <sergiodj@redhat.com>
 
 	* configure: Regenerate.
diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure
index d524ae4..b314c41 100755
--- a/gdb/gdbserver/configure
+++ b/gdb/gdbserver/configure
@@ -7148,7 +7148,7 @@ build_warnings="-Wall -Wpointer-arith \
 -Wno-unused -Wunused-value -Wunused-function \
 -Wno-switch -Wno-char-subscripts \
 -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable \
--Wno-sign-compare -Wno-narrowing"
+-Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized"
 
 # Enable -Wno-format by default when using gcc on mingw since many
 # GCC versions complain about %I64.
diff --git a/gdb/warning.m4 b/gdb/warning.m4
index 83f69ec..98e7453 100644
--- a/gdb/warning.m4
+++ b/gdb/warning.m4
@@ -40,7 +40,7 @@ build_warnings="-Wall -Wpointer-arith \
 -Wno-unused -Wunused-value -Wunused-function \
 -Wno-switch -Wno-char-subscripts \
 -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable \
--Wno-sign-compare -Wno-narrowing"
+-Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized"
 
 # Enable -Wno-format by default when using gcc on mingw since many
 # GCC versions complain about %I64.