This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Constify some commands in ax-gdb.c


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4fd41b2486e0c3407d39a6a4c0bbeedd057eb20e

commit 4fd41b2486e0c3407d39a6a4c0bbeedd057eb20e
Author: Tom Tromey <tom@tromey.com>
Date:   Tue Sep 12 15:00:06 2017 -0600

    Constify some commands in ax-gdb.c
    
    gdb/ChangeLog
    2017-09-27  Tom Tromey  <tom@tromey.com>
    
    	* ax-gdb.c (maint_agent_printf_command, agent_command)
    	(agent_eval_command): Constify.

Diff:
---
 gdb/ChangeLog |  5 +++++
 gdb/ax-gdb.c  | 13 ++++---------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 08705c0..cd6e3e4 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2017-09-27  Tom Tromey  <tom@tromey.com>
 
+	* ax-gdb.c (maint_agent_printf_command, agent_command)
+	(agent_eval_command): Constify.
+
+2017-09-27  Tom Tromey  <tom@tromey.com>
+
 	* tracepoint.c (info_scope_command): Constify.
 	* python/python.c (gdbpy_decode_line): Constify.
 	* python/py-breakpoint.c (bppy_init): Constify.
diff --git a/gdb/ax-gdb.c b/gdb/ax-gdb.c
index c4bf2a6..52ca081 100644
--- a/gdb/ax-gdb.c
+++ b/gdb/ax-gdb.c
@@ -158,8 +158,6 @@ static void gen_expr_binop_rest (struct expression *exp,
 				 struct axs_value *value,
 				 struct axs_value *value1,
 				 struct axs_value *value2);
-
-static void agent_command (char *exp, int from_tty);
 
 
 /* Detecting constant expressions.  */
@@ -2661,7 +2659,7 @@ agent_command_1 (const char *exp, int eval)
 }
 
 static void
-agent_command (char *exp, int from_tty)
+agent_command (const char *exp, int from_tty)
 {
   agent_command_1 (exp, 0);
 }
@@ -2671,7 +2669,7 @@ agent_command (char *exp, int from_tty)
    expression.  */
 
 static void
-agent_eval_command (char *exp, int from_tty)
+agent_eval_command (const char *exp, int from_tty)
 {
   agent_command_1 (exp, 1);
 }
@@ -2680,12 +2678,11 @@ agent_eval_command (char *exp, int from_tty)
    that does a printf, and display the resulting expression.  */
 
 static void
-maint_agent_printf_command (char *exp, int from_tty)
+maint_agent_printf_command (const char *cmdrest, int from_tty)
 {
   struct cleanup *old_chain = 0;
   struct expression *argvec[100];
   struct frame_info *fi = get_current_frame ();	/* need current scope */
-  const char *cmdrest;
   const char *format_start, *format_end;
   struct format_piece *fpieces;
   int nargs;
@@ -2697,11 +2694,9 @@ maint_agent_printf_command (char *exp, int from_tty)
   if (overlay_debugging)
     error (_("GDB can't do agent expression translation with overlays."));
 
-  if (exp == 0)
+  if (cmdrest == 0)
     error_no_arg (_("expression to translate"));
 
-  cmdrest = exp;
-
   cmdrest = skip_spaces (cmdrest);
 
   if (*cmdrest++ != '"')


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]