This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Remove obsolete assertion from regcache.c
- From: Tom Tromey <tromey at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 17 Oct 2017 12:43:23 -0000
- Subject: [binutils-gdb] Remove obsolete assertion from regcache.c
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=57e12da97f8dbe2ad5b4f59bf89c709c4d66600d
commit 57e12da97f8dbe2ad5b4f59bf89c709c4d66600d
Author: Tom Tromey <tom@tromey.com>
Date: Tue Oct 17 06:40:22 2017 -0600
Remove obsolete assertion from regcache.c
When building I got:
../../binutils-gdb/gdb/regcache.c:935:24: error: the address of â??ssize_t read(int, void*, size_t)â?? will never be NULL [-Werror=address]
This happens because "read" used to be a parameter to this function,
which was then removed; but the assertion wasn't updated.
I don't think the assertion is relevant any more, to this removes it.
I'm checking it in as obvious.
2017-10-17 Tom Tromey <tom@tromey.com>
* regcache.c (regcache::xfer_part): Remove assertion.
Diff:
---
gdb/ChangeLog | 4 ++++
gdb/regcache.c | 1 -
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 65952c4..0487dab 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2017-10-17 Tom Tromey <tom@tromey.com>
+
+ * regcache.c (regcache::xfer_part): Remove assertion.
+
2017-10-17 Pedro Alves <palves@redhat.com>
* xml-support.c (xml_fetch_content_from_file): Call
diff --git a/gdb/regcache.c b/gdb/regcache.c
index 555db57..603d2f2 100644
--- a/gdb/regcache.c
+++ b/gdb/regcache.c
@@ -932,7 +932,6 @@ regcache::xfer_part (int regnum, int offset, int len, void *in,
{
enum register_status status;
- gdb_assert (read != NULL);
if (is_raw)
status = raw_read (regnum, reg);
else