This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Fix unstable test names in gdb.gdb/unittest.exp
- From: Pedro Alves <palves at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 24 Oct 2017 09:57:58 -0000
- Subject: [binutils-gdb] Fix unstable test names in gdb.gdb/unittest.exp
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=fee6da6e1d96796f8aa8308b3833a3e4cdb409ff
commit fee6da6e1d96796f8aa8308b3833a3e4cdb409ff
Author: Pedro Alves <palves@redhat.com>
Date: Tue Oct 24 10:43:34 2017 +0100
Fix unstable test names in gdb.gdb/unittest.exp
Currently, if you diff testsuite/gdb.sum of two builds built from different
source directories you see this spurious hunk:
-PASS: gdb.gdb/unittest.exp: maintenance check xml-descriptions /home/pedro/gdb1/src/gdb/testsuite/../features
+PASS: gdb.gdb/unittest.exp: maintenance check xml-descriptions /home/pedro/gdb2/src/gdb/testsuite/../features
After this commit we'll show instead:
PASS: gdb.gdb/unittest.exp: maintenance check xml-descriptions ${srcdir}/../features
gdb/testsuite/ChangeLog:
2017-10-24 Pedro Alves <palves@redhat.com>
* gdb.gdb/unittest.exp ('maintenance check xml-descriptions'): Use
custom test name.
Diff:
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/gdb.gdb/unittest.exp | 3 ++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 36c2b95..31a2172 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,10 @@
2017-10-24 Pedro Alves <palves@redhat.com>
+ * gdb.gdb/unittest.exp ('maintenance check xml-descriptions'): Use
+ custom test name.
+
+2017-10-24 Pedro Alves <palves@redhat.com>
+
* gdb.base/startup-with-shell.exp ('touch $unique_file'): Don't
include the unstable output directory name in the test's name.
(initial_setup_simple) <'set args'>: Use custom test name.
diff --git a/gdb/testsuite/gdb.gdb/unittest.exp b/gdb/testsuite/gdb.gdb/unittest.exp
index c3e36e6..58494e1 100644
--- a/gdb/testsuite/gdb.gdb/unittest.exp
+++ b/gdb/testsuite/gdb.gdb/unittest.exp
@@ -18,5 +18,6 @@ gdb_test "maintenance selftest" "Ran $decimal unit tests, 0 failed"
if { ![is_remote host] } {
gdb_test "maintenance check xml-descriptions ${srcdir}/../features" \
- "Tested $decimal XML files, 0 failed"
+ "Tested $decimal XML files, 0 failed" \
+ "maintenance check xml-descriptions \${srcdir}/../features"
}