This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] gdb.ada/minsyms.exp: Don't hardcode the variable's address
- From: Pedro Alves <palves at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 21 Nov 2017 17:07:07 -0000
- Subject: [binutils-gdb] gdb.ada/minsyms.exp: Don't hardcode the variable's address
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a25d69c6dcbabf3f6629b847246ffb4ddbc29472
commit a25d69c6dcbabf3f6629b847246ffb4ddbc29472
Author: Pedro Alves <palves@redhat.com>
Date: Tue Nov 21 16:04:42 2017 +0000
gdb.ada/minsyms.exp: Don't hardcode the variable's address
This new testcase has a test that fails like this here:
$1 = (<data variable, no debug info> *) 0x60208c <some_minsym>
(gdb) FAIL: gdb.ada/minsyms.exp: print &some_minsym
The problem is that the testcase hardcodes an expected address for the
"some_minsym" variable, which obviously isn't stable.
Fix that by expecting $hex instead.
gdb/testsuite/ChangeLog:
2017-11-21 Pedro Alves <palves@redhat.com>
* gdb.ada/minsyms.exp: Accept any address for 'some_minsym'.
Diff:
---
gdb/testsuite/ChangeLog | 4 ++++
gdb/testsuite/gdb.ada/minsyms.exp | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index fa329b4..16d2801 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2017-11-21 Pedro Alves <palves@redhat.com>
+
+ * gdb.ada/minsyms.exp: Accept any address for 'some_minsym'.
+
2017-11-20 Pedro Alves <palves@redhat.com>
* gdb.base/whatis-ptype-typedefs.c (double_typedef)
diff --git a/gdb/testsuite/gdb.ada/minsyms.exp b/gdb/testsuite/gdb.ada/minsyms.exp
index 2c91125..9878f9f 100644
--- a/gdb/testsuite/gdb.ada/minsyms.exp
+++ b/gdb/testsuite/gdb.ada/minsyms.exp
@@ -35,7 +35,7 @@ gdb_test "print integer(some_minsym)" \
" = 1234"
gdb_test "print &some_minsym" \
- " = \\(access <data variable, no debug info>\\) 0x62c2f8 <some_minsym>"
+ " = \\(access <data variable, no debug info>\\) $hex <some_minsym>"
gdb_test "print /x integer(&some_minsym)" \
" = $hex"