This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] set ret signed in arm_record_extension_space
- From: Yao Qi <qiyao at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 1 Feb 2018 15:10:30 -0000
- Subject: [binutils-gdb] set ret signed in arm_record_extension_space
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=df95a9cf09867c237ddf9b4eb65a990e86de1e17
commit df95a9cf09867c237ddf9b4eb65a990e86de1e17
Author: Yao Qi <yao.qi@linaro.org>
Date: Thu Feb 1 15:09:44 2018 +0000
set ret signed in arm_record_extension_space
Variable 'ret' should be int rather than unsigned, as it can be -1.
gdb:
2018-02-01 Yao Qi <yao.qi@linaro.org>
* arm-tdep.c (arm_record_extension_space): Change ret to signed.
Diff:
---
gdb/ChangeLog | 4 ++++
gdb/arm-tdep.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 90986ef..5c3338f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2018-02-01 Yao Qi <yao.qi@linaro.org>
+
+ * arm-tdep.c (arm_record_extension_space): Change ret to signed.
+
2018-01-31 Nikola Prica <nikola.prica@rt-rk.com>
* rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
index 2e43489..d991e7e 100644
--- a/gdb/arm-tdep.c
+++ b/gdb/arm-tdep.c
@@ -9964,7 +9964,7 @@ arm_record_strx (insn_decode_record *arm_insn_r, uint32_t *record_buf,
static int
arm_record_extension_space (insn_decode_record *arm_insn_r)
{
- uint32_t ret = 0; /* Return value: -1:record failure ; 0:success */
+ int ret = 0; /* Return value: -1:record failure ; 0:success */
uint32_t opcode1 = 0, opcode2 = 0, insn_op1 = 0;
uint32_t record_buf[8], record_buf_mem[8];
uint32_t reg_src1 = 0;