This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Remove MAX_REGISTER_SIZE define


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4ef0bef68cfc777e59156fce1563583c0ffb76d9

commit 4ef0bef68cfc777e59156fce1563583c0ffb76d9
Author: Alan Hayward <alan.hayward@arm.com>
Date:   Thu Mar 8 09:42:21 2018 +0000

    Remove MAX_REGISTER_SIZE define
    
    gdb/
    	* defs.h: Remove MAX_REGISTER_SIZE.
    	* regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
    	asserts.
    	* python/py-unwind.c (pyuw_sniffer): Likewise.

Diff:
---
 gdb/ChangeLog          | 7 +++++++
 gdb/defs.h             | 5 -----
 gdb/python/py-unwind.c | 1 -
 gdb/regcache.c         | 2 --
 4 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 49b91e1..f10476b 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2018-03-07  Alan Hayward  <alan.hayward@arm.com>
+
+	* defs.h: Remove MAX_REGISTER_SIZE.
+	* regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
+	asserts.
+	* python/py-unwind.c (pyuw_sniffer): Likewise.
+
 2018-03-07  Tom Tromey  <tom@tromey.com>
 
 	* linux-tdep.c (linux_info_proc): Update.
diff --git a/gdb/defs.h b/gdb/defs.h
index a924573..9198875 100644
--- a/gdb/defs.h
+++ b/gdb/defs.h
@@ -531,11 +531,6 @@ enum symbol_needs_kind
 /* Dynamic target-system-dependent parameters for GDB.  */
 #include "gdbarch.h"
 
-/* * Maximum size of a register.  Something small, but large enough for
-   all known ISAs.  If it turns out to be too small, make it bigger.  */
-
-enum { MAX_REGISTER_SIZE = 64 };
-
 /* In findvar.c.  */
 
 template<typename T, typename = RequireLongest<T>>
diff --git a/gdb/python/py-unwind.c b/gdb/python/py-unwind.c
index a7e3a93..906a004 100644
--- a/gdb/python/py-unwind.c
+++ b/gdb/python/py-unwind.c
@@ -583,7 +583,6 @@ pyuw_sniffer (const struct frame_unwind *self, struct frame_info *this_frame,
         /* `value' validation was done before, just assert.  */
         gdb_assert (value != NULL);
         gdb_assert (data_size == TYPE_LENGTH (value_type (value)));
-        gdb_assert (data_size <= MAX_REGISTER_SIZE);
 
 	cached_frame->reg[i].data = (gdb_byte *) xmalloc (data_size);
         memcpy (cached_frame->reg[i].data, value_contents (value), data_size);
diff --git a/gdb/regcache.c b/gdb/regcache.c
index 40c58a0..8e843b2 100644
--- a/gdb/regcache.c
+++ b/gdb/regcache.c
@@ -117,7 +117,6 @@ init_regcache_descr (struct gdbarch *gdbarch)
 	descr->sizeof_register[i] = TYPE_LENGTH (descr->register_type[i]);
 	descr->register_offset[i] = offset;
 	offset += descr->sizeof_register[i];
-	gdb_assert (MAX_REGISTER_SIZE >= descr->sizeof_register[i]);
       }
     /* Set the real size of the raw register cache buffer.  */
     descr->sizeof_raw_registers = offset;
@@ -127,7 +126,6 @@ init_regcache_descr (struct gdbarch *gdbarch)
 	descr->sizeof_register[i] = TYPE_LENGTH (descr->register_type[i]);
 	descr->register_offset[i] = offset;
 	offset += descr->sizeof_register[i];
-	gdb_assert (MAX_REGISTER_SIZE >= descr->sizeof_register[i]);
       }
     /* Set the real size of the readonly register cache buffer.  */
     descr->sizeof_cooked_registers = offset;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]