This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Remove struct keyword from section_addr_info


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4f7ae6f5059924a5acc4490880449d6410dc5c93

commit 4f7ae6f5059924a5acc4490880449d6410dc5c93
Author: Keith Seitz <keiths@redhat.com>
Date:   Mon Mar 26 10:34:28 2018 -0700

    Remove struct keyword from section_addr_info
    
    Buildbot pointed out a failiure in windows-nat.c:
    
    ../../binutils-gdb/gdb/windows-nat.c:582:10: error: using typedef-name 'section_addr_info' after 'struct'
       struct section_addr_info *addrs;
              ^~~~~~~~~~~~~~~~~
    In file included from ../../binutils-gdb/gdb/windows-nat.c:49:0:
    ../../binutils-gdb/gdb/symfile.h:75:37: note: 'section_addr_info' has a previous declaration here
     typedef std::vector<other_sections> section_addr_info;
                                         ^~~~~~~~~~~~~~~~~
    
    A recursive grep of the sources for "struct section_addr_info" reveals one
    additional reference in a comment.  In both cases, this patch simply removes
    the struct keyword.
    
    gdb/ChangeLog:
    
    	* symfile.c (place_section): Remove "struct" from section_addr_info
    	in comment.
    	* windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
    	"struct" keyword from section_addr_info.

Diff:
---
 gdb/ChangeLog     | 7 +++++++
 gdb/symfile.c     | 2 +-
 gdb/windows-nat.c | 2 +-
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 20bf941..6de3150 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2018-03-26  Keith Seitz  <keiths@redhat.com>
+
+	* symfile.c (place_section): Remove "struct" from section_addr_info
+	in comment.
+	* windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
+	"struct" keyword from section_addr_info.
+
 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
 
 	* regformats/regdef.h (reg): Add constructors.
diff --git a/gdb/symfile.c b/gdb/symfile.c
index 9571664..1e5297e 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -412,7 +412,7 @@ place_section (bfd *abfd, asection *sect, void *obj)
   arg->lowest = start_addr + bfd_get_section_size (sect);
 }
 
-/* Store struct section_addr_info as prepared (made relative and with SECTINDEX
+/* Store section_addr_info as prepared (made relative and with SECTINDEX
    filled-in) by addr_info_make_relative into SECTION_OFFSETS of NUM_SECTIONS
    entries.  */
 
diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index f849f1f..430cc60 100644
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -579,7 +579,7 @@ struct safe_symbol_file_add_args
 {
   char *name;
   int from_tty;
-  struct section_addr_info *addrs;
+  section_addr_info *addrs;
   int mainline;
   int flags;
   struct ui_file *err, *out;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]