This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Add missing "breaks"


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=15c9ffd6977a93869243dce04988cbaa8340bb00

commit 15c9ffd6977a93869243dce04988cbaa8340bb00
Author: Tom Tromey <tom@tromey.com>
Date:   Thu Apr 19 14:48:51 2018 -0600

    Add missing "breaks"
    
    This adds a "break" to a couple of spots where it was erroneously
    omitted.  I think these are the two (potential) real bugs caught by
    this series.
    
    2018-05-04  Tom Tromey  <tom@tromey.com>
    
    	* mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
    	Add missing "break".
    	* mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
    	Add missing "break".

Diff:
---
 gdb/ChangeLog         | 7 +++++++
 gdb/mi/mi-cmd-stack.c | 1 +
 gdb/mi/mi-main.c      | 1 +
 3 files changed, 9 insertions(+)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c0deadf..c2f521c 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,12 @@
 2018-05-04  Tom Tromey  <tom@tromey.com>
 
+	* mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
+	Add missing "break".
+	* mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
+	Add missing "break".
+
+2018-05-04  Tom Tromey  <tom@tromey.com>
+
 	* rs6000-tdep.c (ppc_process_record_op4)
 	(ppc_process_record_op63): Add fall-through comment.
 
diff --git a/gdb/mi/mi-cmd-stack.c b/gdb/mi/mi-cmd-stack.c
index 443d1ed..52660bd 100644
--- a/gdb/mi/mi-cmd-stack.c
+++ b/gdb/mi/mi-cmd-stack.c
@@ -245,6 +245,7 @@ mi_cmd_stack_list_locals (const char *command, char **argv, int argc)
 	    {
 	    case NO_FRAME_FILTERS:
 	      raw_arg = oind;
+	      break;
 	    case SKIP_UNAVAILABLE:
 	      skip_unavailable = 1;
 	      break;
diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c
index 51d0a26..13556d4 100644
--- a/gdb/mi/mi-main.c
+++ b/gdb/mi/mi-main.c
@@ -2568,6 +2568,7 @@ mi_cmd_trace_frame_collected (const char *command, char **argv, int argc)
 	  break;
 	case REGISTERS_FORMAT:
 	  registers_format = oarg[0];
+	  break;
 	case MEMORY_CONTENTS:
 	  memory_contents = 1;
 	  break;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]