This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Do not look at file symbols when reading psymtabs
- From: Tom Tromey <tromey at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 20 Jul 2018 15:48:59 -0000
- Subject: [binutils-gdb] Do not look at file symbols when reading psymtabs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f62f6af5da07eba0ac5425365da3d82c43f3445c
commit f62f6af5da07eba0ac5425365da3d82c43f3445c
Author: Tom Tromey <tom@tromey.com>
Date: Mon May 21 23:23:02 2018 -0600
Do not look at file symbols when reading psymtabs
The DWARF reader was setting the list_in_scope member when reading
partial symbols. however, this member is only useful when reading
full symbols. Future patches will make this assert, so remove these
unneeded initializations.
gdb/ChangeLog
2018-07-20 Tom Tromey <tom@tromey.com>
* dwarf2read.c (process_psymtab_comp_unit_reader)
(build_type_psymtabs_reader): Do not set list_in_scope.
Diff:
---
gdb/ChangeLog | 5 +++++
gdb/dwarf2read.c | 3 ---
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index f41f4e1..96b54fb 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2018-07-20 Tom Tromey <tom@tromey.com>
+ * dwarf2read.c (process_psymtab_comp_unit_reader)
+ (build_type_psymtabs_reader): Do not set list_in_scope.
+
+2018-07-20 Tom Tromey <tom@tromey.com>
+
* buildsym.c (free_pendings): Remove.
(add_symbol_to_list, scoped_free_pendings)
(finish_block_internal, buildsym_init): Update.
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index e6a8a18..bdd1c9a 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -7908,8 +7908,6 @@ process_psymtab_comp_unit_reader (const struct die_reader_specs *reader,
prepare_one_comp_unit (cu, comp_unit_die, info->pretend_language);
- cu->list_in_scope = &file_symbols;
-
/* Allocate a new partial symbol table structure. */
filename = dwarf2_string_attr (comp_unit_die, DW_AT_name, cu);
if (filename == NULL)
@@ -8077,7 +8075,6 @@ build_type_psymtabs_reader (const struct die_reader_specs *reader,
VEC_safe_push (sig_type_ptr, tu_group->tus, sig_type);
prepare_one_comp_unit (cu, type_unit_die, language_minimal);
- cu->list_in_scope = &file_symbols;
pst = create_partial_symtab (per_cu, "");
pst->anonymous = 1;