This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Remove an unused variable from spu_get_overlay_table


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f4e80e1301f916ae7952abaf4ff1ebeac00951b3

commit f4e80e1301f916ae7952abaf4ff1ebeac00951b3
Author: Tom Tromey <tom@tromey.com>
Date:   Mon Jul 16 09:33:42 2018 -0600

    Remove an unused variable from spu_get_overlay_table
    
    This removes an unused variable from spu_get_overlay_table, replacing
    it with an explanatory comment.
    
    gdb/ChangeLog
    2018-07-22  Tom Tromey  <tom@tromey.com>
    
    	* spu-tdep.c (spu_get_overlay_table): Remove unused variable.

Diff:
---
 gdb/ChangeLog  | 4 ++++
 gdb/spu-tdep.c | 4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 2bbb8b3..67315f7 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
 2018-07-22  Tom Tromey  <tom@tromey.com>
 
+	* spu-tdep.c (spu_get_overlay_table): Remove unused variable.
+
+2018-07-22  Tom Tromey  <tom@tromey.com>
+
 	* guile/scm-value.c (gdbscm_value_call): Remove unused variables.
 	* guile/scm-math.c (vlscm_unop_gdbthrow, vlscm_binop_gdbthrow)
 	(vlscm_convert_typed_value_from_scheme): Remove unused variable.
diff --git a/gdb/spu-tdep.c b/gdb/spu-tdep.c
index c85a740..6ae37f5 100644
--- a/gdb/spu-tdep.c
+++ b/gdb/spu-tdep.c
@@ -1820,8 +1820,8 @@ spu_get_overlay_table (struct objfile *objfile)
     {
       CORE_ADDR vma  = extract_unsigned_integer (ovly_table + 16*i + 0,
 						 4, byte_order);
-      CORE_ADDR size = extract_unsigned_integer (ovly_table + 16*i + 4,
-						 4, byte_order);
+      /* Note that this skips the "size" entry, which is at offset
+	 4.  */
       CORE_ADDR pos  = extract_unsigned_integer (ovly_table + 16*i + 8,
 						 4, byte_order);
       CORE_ADDR buf  = extract_unsigned_integer (ovly_table + 16*i + 12,


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]