This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Remove unused variables in procfs.c etc.
- From: Rainer Orth <ro at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 6 Aug 2018 11:57:16 -0000
- Subject: [binutils-gdb] Remove unused variables in procfs.c etc.
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=821a26825bdcb96358a51f5c2140475951429470
commit 821a26825bdcb96358a51f5c2140475951429470
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date: Mon Aug 6 13:54:34 2018 +0200
Remove unused variables in procfs.c etc.
The recent patch to enable -Wunused-variable uncovered a couple of
instances in Solaris-specific files:
/vol/src/gnu/gdb/hg/master/dist/gdb/proc-api.c: In function â??void _initialize_proc_api()â??:
/vol/src/gnu/gdb/hg/master/dist/gdb/proc-api.c:422:28: error: unused variable â??câ?? [-Werror=unused-variable]
struct cmd_list_element *c;
^
/vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c: In function â??void procfs_init_inferior(target_ops*, int)â??:
/vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c:2895:12: error: unused variable â??signalsâ?? [-Werror=unused-variable]
sigset_t signals;
^~~~~~~
/vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c: In member function â??virtual char* procfs_target::make_corefile_notes(bfd*, int*)â??:
/vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c:3845:19: error: unused variable â??old_chainâ?? [-Werror=unused-variable]
struct cleanup *old_chain;
^~~~~~~~~
/vol/src/gnu/gdb/hg/master/dist/gdb/procfs.c:3847:18: error: unused variable â??fpregsâ?? [-Werror=unused-variable]
gdb_fpregset_t fpregs;
^~~~~~
Fixed as follows. Tested on amd64-pc-solaris2.11, installed as obvious.
* proc-api.c (_initialize_proc_api): Remove c, unused.
* procfs.c (procfs_init_inferior): Remove signals, unused.
(procfs_target::make_corefile_notes): Remove old_chain, fpregs,
unused.
Diff:
---
gdb/ChangeLog | 7 +++++++
gdb/proc-api.c | 2 --
gdb/procfs.c | 3 ---
3 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0d38674..55930d0 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2018-08-06 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
+
+ * proc-api.c (_initialize_proc_api): Remove c, unused.
+ * procfs.c (procfs_init_inferior): Remove signals, unused.
+ (procfs_target::make_corefile_notes): Remove old_chain, fpregs,
+ unused.
+
2018-08-06 Sergey Korolev <s.korolev@ndmsystems.com>
Andrew Burgess <andrew.burgess@embecosm.com>
diff --git a/gdb/proc-api.c b/gdb/proc-api.c
index 75e8055..ab160b1 100644
--- a/gdb/proc-api.c
+++ b/gdb/proc-api.c
@@ -419,8 +419,6 @@ proc_prettyfprint_status (long flags, int why, int what, int thread)
void
_initialize_proc_api (void)
{
- struct cmd_list_element *c;
-
add_setshow_boolean_cmd ("procfs-trace", no_class, &procfs_trace, _("\
Set tracing for /proc api calls."), _("\
Show tracing for /proc api calls."), NULL,
diff --git a/gdb/procfs.c b/gdb/procfs.c
index e6c6066..ec34650 100644
--- a/gdb/procfs.c
+++ b/gdb/procfs.c
@@ -2892,7 +2892,6 @@ static void
procfs_init_inferior (struct target_ops *ops, int pid)
{
procinfo *pi;
- sigset_t signals;
int fail;
int lwpid;
@@ -3842,9 +3841,7 @@ find_stop_signal (void)
char *
procfs_target::make_corefile_notes (bfd *obfd, int *note_size)
{
- struct cleanup *old_chain;
gdb_gregset_t gregs;
- gdb_fpregset_t fpregs;
char fname[16] = {'\0'};
char psargs[80] = {'\0'};
procinfo *pi = find_procinfo_or_die (inferior_ptid.pid (), 0);