This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Remove unnecessary ternary operator in m32c-tdep.c


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a4497d2f8486502ab5140ec5168d5f13ec375155

commit a4497d2f8486502ab5140ec5168d5f13ec375155
Author: Simon Marchi <simon.marchi@ericsson.com>
Date:   Tue Aug 21 10:47:47 2018 -0400

    Remove unnecessary ternary operator in m32c-tdep.c
    
    Bug 17816 pointed out a useless use of the ternary operator:
    
      case 0x0: sd.reg = (size == 1 ? &st->r0 : &st->r0); break;
    
    I believe that this is right.  If size is 1, the instruction refers to
    part of r0, while if size is 2, the instruction refers to the whole of
    r0.
    
    gdb/ChangeLog:
    
    	PR gdb/17816
    	* m32c-tdep.c (m32c_decode_srcdest4): Remove unnecessary ternary
    	operator.

Diff:
---
 gdb/ChangeLog   | 6 ++++++
 gdb/m32c-tdep.c | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ff4d1cb..9173bf9 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2018-08-21  Simon Marchi  <simon.marchi@ericsson.com>
+
+	PR gdb/17816
+	* m32c-tdep.c (m32c_decode_srcdest4): Remove unnecessary ternary
+	operator.
+
 2018-08-19  Simon Marchi  <simon.marchi@polymtl.ca>
 
 	* solib-svr4.c (svr4_exec_displacement): Fix formatting.
diff --git a/gdb/m32c-tdep.c b/gdb/m32c-tdep.c
index fc6277e..6fa2445 100644
--- a/gdb/m32c-tdep.c
+++ b/gdb/m32c-tdep.c
@@ -1236,7 +1236,7 @@ m32c_decode_srcdest4 (struct m32c_pv_state *st,
 
   switch (code)
     {
-    case 0x0: sd.reg = (size == 1 ? &st->r0 : &st->r0); break;
+    case 0x0: sd.reg = &st->r0; break;
     case 0x1: sd.reg = (size == 1 ? &st->r0 : &st->r1); break;
     case 0x2: sd.reg = (size == 1 ? &st->r1 : &st->r2); break;
     case 0x3: sd.reg = (size == 1 ? &st->r1 : &st->r3); break;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]