[binutils-gdb] OBVIOUS Remove a useless const char *type and its initialization.

[Philippe Waroquiers <philippe at sourceware dot org>]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=814fa4f632006dace09b131021b949021dfb58bf

commit 814fa4f632006dace09b131021b949021dfb58bf
Author: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Date:   Sat Nov 3 19:31:41 2018 +0100

    OBVIOUS Remove a useless const char *type and its initialization.
    
    Valgrind detected a leak for the line:
      type = xstrdup ("auto");
    
    as the compile probably dropped the type variable completely, as its
    only usage was this initialization.
    
    So, remove the useless variable.

Diff:
---
 gdb/ChangeLog  | 5 +++++
 gdb/language.c | 4 +---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 95591f6..87db7f5 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-11-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
+
+	* language.c (type): Remove.
+	(_initialize_language): Remove assignment to type.
+
 2018-11-02  Joel Brobecker  <brobecker@adacore.com>
 
 	* aarch64-ravenscar-thread.h, aarch64-ravenscar-thread.c: New files.
diff --git a/gdb/language.c b/gdb/language.c
index 21eda57..e2f4001 100644
--- a/gdb/language.c
+++ b/gdb/language.c
@@ -105,10 +105,9 @@ static const struct language_defn *languages[] = {
   &ada_language_defn,
 };
 
-/* The current values of the "set language/type/range" enum
+/* The current values of the "set language/range/case-sensitive" enum
    commands.  */
 static const char *language;
-static const char *type;
 static const char *range;
 static const char *case_sensitive;
 
@@ -1174,7 +1173,6 @@ For Fortran the default is off; for other languages the default is on."),
   add_set_language_command ();
 
   language = xstrdup ("auto");
-  type = xstrdup ("auto");
   range = xstrdup ("auto");
   case_sensitive = xstrdup ("auto");