[binutils-gdb] Aarch64: Fix segfault when casting dummy calls

[Alan Hayward <alahay01 at sourceware dot org>]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=38a72da0f1d968432ae6a2a9697ba55932dc075e

commit 38a72da0f1d968432ae6a2a9697ba55932dc075e
Author: Alan Hayward <alan.hayward@arm.com>
Date:   Thu Oct 11 14:47:30 2018 +0100

    Aarch64: Fix segfault when casting dummy calls
    
    The following will segfault on aarch64 if foo is in another object,
    was compiled as c++ and has no debug symbols:
    (gdb) p (int)foo()
    
    This is because aarch64_push_dummy_call determines the return type
    of the function and then does not check for null pointer.
    
    A null pointer for the return type means the call has no debug
    information.  For the code to get here, then the call must have
    been cast, otherwise we'd error out sooner.  In the case of a
    no-debug-info call cast, the return type is the type the user
    had cast the call to, but we do not have that information
    available here.
    
    However, aarch64_push_dummy_call only requires the return type in
    order to calculate lang_struct_return. This information is available
    in the return_method enum. The fix is to simply use this instead.
    
    Adds testcase to check calls across objects, with all combinations
    of c, c++, debug and no debug.
    
    gdb/ChangeLog:
    
    	PR gdb/22736:
    	* aarch64-tdep.c (aarch64_push_dummy_call): Remove
    	lang_struct_return code.
    
    gdb/testsuite/ChangeLog:
    
    	PR gdb/22736:
    	* gdb.cp/infcall-nodebug-lib.c: New test.
    	* gdb.cp/infcall-nodebug-main.c: New test.
    	* gdb.cp/infcall-nodebug.exp: New file.

Diff:
---
 gdb/ChangeLog                               |   6 ++
 gdb/aarch64-tdep.c                          |  32 +-------
 gdb/testsuite/ChangeLog                     |   7 ++
 gdb/testsuite/gdb.cp/infcall-nodebug-lib.c  |  22 +++++
 gdb/testsuite/gdb.cp/infcall-nodebug-main.c |  24 ++++++
 gdb/testsuite/gdb.cp/infcall-nodebug.exp    | 119 ++++++++++++++++++++++++++++
 6 files changed, 182 insertions(+), 28 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4ff2767..4995d55 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
 2018-11-16  Alan Hayward  <alan.hayward@arm.com>
 
+	PR gdb/22736:
+	* aarch64-tdep.c (aarch64_push_dummy_call): Remove
+	lang_struct_return code.
+
+2018-11-16  Alan Hayward  <alan.hayward@arm.com>
+
 	* aarch64-tdep.c (aarch64_push_dummy_call): Replace arg with
 	return_method.
 	* alpha-tdep.c (alpha_push_dummy_call): Likewise.
diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index 7a0d5b3..ae56c9c 100644
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -1520,9 +1520,6 @@ aarch64_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
 {
   int argnum;
   struct aarch64_call_info info;
-  struct type *func_type;
-  struct type *return_type;
-  int lang_struct_return;
 
   memset (&info, 0, sizeof (info));
 
@@ -1544,42 +1541,21 @@ aarch64_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
      If the language code decides to pass in memory we want to move
      the pointer inserted as the initial argument from the argument
      list and into X8, the conventional AArch64 struct return pointer
-     register.
-
-     This is slightly awkward, ideally the flag "lang_struct_return"
-     would be passed to the targets implementation of push_dummy_call.
-     Rather that change the target interface we call the language code
-     directly ourselves.  */
-
-  func_type = check_typedef (value_type (function));
-
-  /* Dereference function pointer types.  */
-  if (TYPE_CODE (func_type) == TYPE_CODE_PTR)
-    func_type = TYPE_TARGET_TYPE (func_type);
-
-  gdb_assert (TYPE_CODE (func_type) == TYPE_CODE_FUNC
-	      || TYPE_CODE (func_type) == TYPE_CODE_METHOD);
-
-  /* If language_pass_by_reference () returned true we will have been
-     given an additional initial argument, a hidden pointer to the
-     return slot in memory.  */
-  return_type = TYPE_TARGET_TYPE (func_type);
-  lang_struct_return = language_pass_by_reference (return_type);
+     register.  */
 
   /* Set the return address.  For the AArch64, the return breakpoint
      is always at BP_ADDR.  */
   regcache_cooked_write_unsigned (regcache, AARCH64_LR_REGNUM, bp_addr);
 
-  /* If we were given an initial argument for the return slot because
-     lang_struct_return was true, lose it.  */
-  if (lang_struct_return)
+  /* If we were given an initial argument for the return slot, lose it.  */
+  if (return_method == return_method_hidden_param)
     {
       args++;
       nargs--;
     }
 
   /* The struct_return pointer occupies X8.  */
-  if (return_method == return_method_struct || lang_struct_return)
+  if (return_method != return_method_normal)
     {
       if (aarch64_debug)
 	{
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 90faeda..c0de6f2 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,10 @@
+2018-11-16  Alan Hayward  <alan.hayward@arm.com>
+
+	PR gdb/22736:
+	* gdb.cp/infcall-nodebug-lib.c: New test.
+	* gdb.cp/infcall-nodebug-main.c: New test.
+	* gdb.cp/infcall-nodebug.exp: New file.
+
 2018-11-12  Simon Marchi  <simon.marchi@polymtl.ca>
 
 	* gdb.base/skip.exp: Add standard_testfile.  Add "skip delete"
diff --git a/gdb/testsuite/gdb.cp/infcall-nodebug-lib.c b/gdb/testsuite/gdb.cp/infcall-nodebug-lib.c
new file mode 100644
index 0000000..92746f2
--- /dev/null
+++ b/gdb/testsuite/gdb.cp/infcall-nodebug-lib.c
@@ -0,0 +1,22 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+   Copyright 2018 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+int
+foo (void)
+{
+  return 1;
+}
diff --git a/gdb/testsuite/gdb.cp/infcall-nodebug-main.c b/gdb/testsuite/gdb.cp/infcall-nodebug-main.c
new file mode 100644
index 0000000..b623a4a
--- /dev/null
+++ b/gdb/testsuite/gdb.cp/infcall-nodebug-main.c
@@ -0,0 +1,24 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+   Copyright 2018 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+extern int foo (void);
+
+int
+main (void)
+{
+  return 0;
+}
diff --git a/gdb/testsuite/gdb.cp/infcall-nodebug.exp b/gdb/testsuite/gdb.cp/infcall-nodebug.exp
new file mode 100644
index 0000000..bb77b64
--- /dev/null
+++ b/gdb/testsuite/gdb.cp/infcall-nodebug.exp
@@ -0,0 +1,119 @@
+# This testcase is part of GDB, the GNU debugger.
+# Copyright 2018 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# Test function calls on C++ functions that have no debug information.
+# See gdb/22736.  Put the called function in a different object to ensure
+# the rest of the test can be complied with debug information.  Whilst we
+# are at it, also test functions with debug information and C functions too.
+
+if [target_info exists gdb,cannot_call_functions] {
+    unsupported "this target can not call functions"
+    continue
+}
+
+# Only test C++ if we are able.  Always use C.
+if { [skip_cplus_tests] || [get_compiler_info "c++"] } {
+    set lang {c}
+} else {
+    set lang {c c++}
+}
+
+set main_basename infcall-nodebug-main
+set lib_basename infcall-nodebug-lib
+standard_testfile ${main_basename}.c ${lib_basename}.c
+
+set mainsrc "${srcdir}/${subdir}/${srcfile}"
+set libsrc "${srcdir}/${subdir}/${srcfile2}"
+
+# Build both source files to objects using language LANG. Use SYMBOLS to build
+# with either debug symbols or without - but always build the main file with
+# debug.  Then make function calls across the files.
+
+proc build_and_run_test { lang symbols } {
+
+    global main_basename lib_basename mainsrc libsrc binfile testfile
+    global gdb_prompt
+
+    if { $symbols == "debug" } {
+	set debug_flags "debug"
+    } else {
+	set debug_flags ""
+    }
+
+    # Setup directory.
+
+    set dir "$lang-$symbols"
+    remote_exec build "rm -rf [standard_output_file ${dir}]"
+    remote_exec build "mkdir -p [standard_output_file ${dir}]"
+
+    # Compile both files to objects, then link together.
+
+    set main_flags "$lang debug"
+    set lib_flags "$lang $debug_flags"
+    set main_o [standard_output_file ${dir}/${main_basename}.o]
+    set lib_o [standard_output_file ${dir}/${lib_basename}.o]
+    set binfile [standard_output_file ${dir}/${testfile}]
+
+    if { [gdb_compile $mainsrc $main_o object ${main_flags}] != "" } {
+	untested "failed to compile main file to object"
+	return -1
+    }
+
+    if { [gdb_compile $libsrc $lib_o object ${lib_flags}] != "" } {
+	untested "failed to compile secondary file to object"
+	return -1
+    }
+
+    if { [gdb_compile "$main_o $lib_o" ${binfile} executable ""] != "" } {
+	untested "failed to compile"
+	return -1
+    }
+
+    # Startup and run to main.
+
+    clean_restart $binfile
+
+    if ![runto_main] then {
+	fail "can't run to main"
+	return
+    }
+
+    # Function call with cast.
+
+    gdb_test "p (int)foo()" " = 1"
+
+    # Function call without cast.  Will error if there are no debug symbols.
+
+    set test "p foo()"
+    gdb_test_multiple $test $test {
+	-re " = 1\r\n$gdb_prompt " {
+	    gdb_assert [ string equal $symbols "debug" ]
+	    pass $test
+	}
+	-re "has unknown return type; cast the call to its declared return type\r\n$gdb_prompt " {
+	    gdb_assert ![ string equal $symbols "debug" ]
+	    pass $test
+	}
+    }
+
+}
+
+foreach_with_prefix l $lang {
+    foreach_with_prefix s {debug nodebug} {
+	build_and_run_test $l $s
+    }
+}
+