This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Remove a comment in compile/compile-cplus-types.c
- From: Tom Tromey <tromey at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 23 Jan 2019 03:50:54 -0000
- Subject: [binutils-gdb] Remove a comment in compile/compile-cplus-types.c
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7af7e9b5d8f9dd8f994d59923158d24d77a54bbe
commit 7af7e9b5d8f9dd8f994d59923158d24d77a54bbe
Author: Tom Tromey <tom@tromey.com>
Date: Mon Jan 21 13:43:16 2019 -0700
Remove a comment in compile/compile-cplus-types.c
The include sorter can't handle multi-line comments on the same line
as a #include. This patch removes the only such comment.
In general I think these sorts of comments do not provide much value:
more often than not, I find that the comment is obsolete in one way or
another, and so the include sorter removes them in most cases.
gdb/ChangeLog
2019-01-22 Tom Tromey <tom@tromey.com>
* compile/compile-cplus-types.c: Remove a comment by #include.
Diff:
---
gdb/ChangeLog | 4 ++++
gdb/compile/compile-cplus-types.c | 3 +--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d557d43..9c1ea0b 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2019-01-22 Tom Tromey <tom@tromey.com>
+ * compile/compile-cplus-types.c: Remove a comment by #include.
+
+2019-01-22 Tom Tromey <tom@tromey.com>
+
* compile/gcc-c-plugin.h: Include compile-internal.h.
2019-01-22 Tom Tromey <tom@tromey.com>
diff --git a/gdb/compile/compile-cplus-types.c b/gdb/compile/compile-cplus-types.c
index 97c4d3c..330589c 100644
--- a/gdb/compile/compile-cplus-types.c
+++ b/gdb/compile/compile-cplus-types.c
@@ -32,8 +32,7 @@
#include "block.h"
#include "gdbcmd.h"
#include "c-lang.h"
-#include "compile-c.h" /* Included for c_get_range_decl_name
- et al. */
+#include "compile-c.h"
#include <algorithm>
/* Default compile flags for C++. */