Re: Linux threads patch for GDB 4.18

[Jim Kingdon <kingdon@redhat.com>]

Graham Stoney wrote me by email but I'm responding to the list since
this may be of interest to others:

> How's the new job at Red Hat going?

Well enough for me, although you really should ask the gcc and gdb
maintainers - since the point of having me here is, roughly speaking,
to improve life for users and developers of gcc and gdb on Linux.

> I tried applying your patch to add Linux threads support to gdb-4.18, from:
>     http://sourceware.cygnus.com/ml/gdb-patches/1999-q3/msg00177.html
> 
> I'm afraid it doesn't apply cleanly; are you sure you're diffing against the
> official gdb-4.18 release? Here's what I got:

The "fuzz" messages are expected (if memory serves - I know I did lots
of cut-and-paste to come up with that patch).

Don't know about the target.h rejection - you can see the patch
exactly as I used it in the gdb-4.18-4.src.rpm package in rawhide (see
http://developer.redhat.com/ for more on rawhide).  That .src.rpm does
apply a few patches to GDB 4.18 which apply before the threads one so
that might have something to do with it.  See http://www.rpm.org/
(recently updated!) if you aren't familiar with RPM - the short summary
is that you can do something like
  rpm2cpio <gdb-4.18-4.src.rpm | cpio --extract --verbose
to get gdb-4.18.tar.gz (should be unmodified from the one found on,
say, ftp.gnu.org), all the patches, and the file "gdb.spec" which
shows which patches get applied in what order.

Perhaps you would like to tidy up the patch and post a cleaner
version.  If you can't figure things out, feel free to ask a more
specific question, but as GDB is a community project I will give you
the opportunity to take care of some of the legwork ;-).

> % patch -p1 < ../ftp/gdbthreads-4.18.patch 
> patching file `gdb/config/i386/linux.mh'
> patching file `gdb/config/i386/nm-linux.h'
> patching file `gdb/config/i386/tm-linux.h'
> Hunk #1 succeeded at 35 with fuzz 2 (offset -69 lines).
> patching file `gdb/inferior.h'
> Hunk #1 succeeded at 254 (offset -6 lines).
> patching file `gdb/infrun.c'
> Hunk #1 succeeded at 3342 with fuzz 2 (offset 51 lines).
> patching file `gdb/linuxthreads.c'
> patching file `gdb/target.c'
> Hunk #2 succeeded at 1469 (offset -103 lines).
> Hunk #3 succeeded at 1731 with fuzz 2 (offset 103 lines).
> patching file `gdb/target.h'
> Hunk #1 FAILED at 48.
> 1 out of 2 hunks FAILED -- saving rejects to gdb/target.h.rej
> 
> Regards,
> Graham