This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Move symfile.c:generic_load()? Was: RFA: patch to remote.c for larger download packet support (part 1)
- To: gdb-patches at sourceware dot cygnus dot com
- Subject: Move symfile.c:generic_load()? Was: RFA: patch to remote.c for larger download packet support (part 1)
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Thu, 14 Oct 1999 17:31:41 +1000
- CC: "Frank Ch. Eigler" <fche at cygnus dot com>
- Organization: Cygnus Solutions
- References: <19991005160552.A1007@cygnus.com>
"Frank Ch. Eigler" wrote:
>
> Hi -
>
> The following patches are one step in loosening the remote protocols'
> packet size limiting code, so that downloads to versatile targets across
> reliable channels may be quicker. This is done by making remote_write_bytes()
> and putpkt() be able to accept packets up to "remotewritesize" bytes in length.
>
> The next step would be generalizing generic_load() to supply larger packets
> when desired.
>
> The first patch is against gdb proper. The second is a new test case family
> that checks the effect of changing the parameter over several repeated
> downloads.
As a corollary to this, Frank also sent me a patch illustrating how
badly GENERIC_LOAD_CHUNK affects download performance (cf
symfile.c:generic_load()).
Before I start on that patch (generic_load needs serious surgery) I'm
wondering if the entire function hould simply be moved to remote.c or
target.c, remote-load.c, generic-load.c, remote-utils.c?
Where it currently lives is simply wierd,
Andrew