This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Re: [RFA]: Fix crashing bug in set follow-fork-mode
- To: "Daniel Berlin+gnu.gdb.bug" <dan at cgsoftware dot com>
- Subject: Re: [RFA]: Fix crashing bug in set follow-fork-mode
- From: Tim Mooney <mooney at dogbert dot cc dot ndsu dot nodak dot edu>
- Date: Sun, 16 Apr 2000 21:28:28 -0500 (CDT)
- cc: gdb-patches at sourceware dot cygnus dot com
In regard to: [RFA]: Fix crashing bug in set follow-fork-mode, Daniel...:
>Forget it
>Reproduced, and fixed.
>It's not even a one liner.
>The enum command list has to be NULL terminated.
>It wasn't, so it screwed us up beyond belief.
>
>Someone please commit this to the branch if it gets approved.
>I have no idea how to make a testcase for it.
>I knew something screwy was up when "set follow-fork-mode parent" said
>"ambiguous command: \"parent\"", and it clearly wasn't ambiguous at
>all.
>
>So, i looked, and it had trashed our stack, and thought we had 6
>million matches, rather than one.
scheduler-lock seems to have the same problem (see the enum at line 765 of
infrun.c). Conditions under which it happens are the exact same as in my
report for the follow-fork-mode problem. I've left the patch to fix the
problem for you or someone else, since it's again very small.
Tim
--
Tim Mooney mooney@dogbert.cc.ndsu.NoDak.edu
Information Technology Services (701) 231-1076 (Voice)
Room 242-J1, IACC Building (701) 231-8541 (Fax)
North Dakota State University, Fargo, ND 58105-5164