This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH]: multi-arch fix for monitor.c


Andrew Cagney wrote:
> 
> Michael Snyder wrote:
> >
> > OK, try #2:
> >
> > 2000-04-26  Michael Snyder  <msnyder@seadog.cygnus.com>
> >
> >         * monitor.c (monitor_fetch_register): MAX_REGISTER_RAW_SIZE
> >         is not static in the MULTI_ARCH world, so don't use it in a
> >         static array declaration.
> 
> I'm not so sure :-(  MAX_REGISTER_RAW_SIZE can change and hence the
> allocated size of zerobuf could need to change.
> 
> What about chaning its only use to write_register (..., 0)?

Sorry, ignore this suggestion.  write_register is for high-level
accesses to GDB.  As Frank suggested, it would be safer to just create
the buffer when it is needed.

	Andrew

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]