Re: Patch to make top-of-tree GDB compile on Digital UNIX

[Andrew Cagney <ac131313 at cygnus dot com>]

Elena Zannoni wrote:

> Index: osfsolib.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/osfsolib.c,v
> retrieving revision 1.2
> diff -c -r1.2 osfsolib.c
> *** osfsolib.c  2000/04/04 02:08:52     1.2
> --- osfsolib.c  2000/04/24 14:42:07
> ***************
> *** 598,604 ****
>         text_addr = bfd_section_vma (so->abfd, lowest_sect) + LM_OFFSET (so);
>       }
> 
> !   section_addrs.text_addr = text_addr;
>     so->objfile = symbol_file_add (so->so_name, so->from_tty,
>                                  &section_addrs, 0, OBJF_SHARED);
>     return (1);
> --- 598,605 ----
>         text_addr = bfd_section_vma (so->abfd, lowest_sect) + LM_OFFSET (so);
>       }
> 
> !   section_addrs.other[0].addr = text_addr;
> !   section_addrs.other[0].name = ".text";
>     so->objfile = symbol_file_add (so->so_name, so->from_tty,
>                                  &section_addrs, 0, OBJF_SHARED);
>     return (1);
> 

I see Elena is working through all the fixes like the above (Thanks)!

> I don't think we have a maintainer for this platform, do we?
> Elena

Which means it is me ....

>  > I also changed "symbol_add_stub()" and "solib_map_sections()" to take a
>  > "PTR" rather than a "char *" as an argument, similar to the signatures
>  > they have in other "*solib.c" files, to eliminate some compiler
>  > warnings; Elena Zannoni suggested to me that "PTR" is deprecated in
>  > favor of "void *", so perhaps "void *" should be used instead.

That is correct.  The output of `grep PTR *.[hc] | wc -l` should be
going down not up :-)

Elena also noted that the patch combined two very different changes. 
It's really important to keep cleanups separate from bug fixes.  You may
find it easier if you have two or more copies of the the GDB source
tree.  That way one tree can be used to create clean patches while
another is used for experimentation.

	enjoy,
		Andrew