Re: [PATCH] Fixups in procfs.c

[Andrew Cagney <ac131313 at cygnus dot com>]

Michael Snyder wrote:
> 

> > Michael,
> >
> > This change has to be wrong.  The extern declaration should be comming
> > from a header file somewhere.
> 
> I appreciate the sentiment (as reflected by my comment).
> There are currently 15 (fifteen) implementations of these
> four functions.  Thirteen of them have an argument of type
> "gregset_t", one has a "prgregset_t", and one has an
> "elf_gregset_t".  None of these functions is declared in any
> header file.  The type itself comes from various different
> system header files, depending on the native OS.
> 
> To cope with this divergence, procfs has its own typedef
> "gdb_gregset_t" which is declared in various different ways
> inside an ugly ifdef.  It calls the function with that, and
> if all goes well, the actual argument will match the appropriate
> version of the formal argument.
> 
> I did not think this ugliness ought to be exported up
> into a local header file, since there are very few users
> of this API.  And anyway, I was only trying to suppress
> a compiler warning.

Ok (ulgh).
I'd suggest expanding on the comment a little with what you've explained
above.

	sorry,
		Andrew