This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Re: [PATCH]: Promote float args on i386 (attn Hurd, Cygwin, DJGPP...)
- To: msnyder at cygnus dot com
- Subject: Re: [PATCH]: Promote float args on i386 (attn Hurd, Cygwin, DJGPP...)
- From: Eli Zaretskii <eliz at delorie dot com>
- Date: Fri, 12 May 2000 16:28:59 -0400 (EDT)
- CC: cgf at cygnus dot com, gdb-patches at sourceware dot cygnus dot com, kettenis at gnu dot org, jtc at redback dot com, nsd at cygnus dot com
- References: <200005120557.WAA05792@cleaver.cygnus.com> <200005121051.GAA14389@indy.delorie.com> <391C1E1C.2386@cygnus.com>
- Reply-to: Eli Zaretskii <eliz at is dot elta dot co dot il>
> Date: Fri, 12 May 2000 08:07:08 -0700
> From: Michael Snyder <msnyder@cygnus.com>
>
> make check RUNTESTFLAGS=callfuncs.exp
> FAIL: gdb.base/callfuncs.exp: p t_float_values(3.14159,-2.3765)
> FAIL: gdb.base/callfuncs.exp: p t_float_values(float_val1,float_val2)
> FAIL: gdb.base/callfuncs.exp: p t_float_values(3.14159,float_val2)
> FAIL: gdb.base/callfuncs.exp: p t_float_values(float_val1,-2.3765)
> FAIL: gdb.base/callfuncs.exp: p t_float_values2(3.14159,float_val2)
Like Mark, I don't see these failures. All of these tests pass for me
with the DJGPP version.
> The problem is that GDB passes the float values as floats,
> while the callee expects them to be doubles.
Hmm... If I put a breakpoint at the beginning of value_push:
static CORE_ADDR
value_push (sp, arg)
register CORE_ADDR sp;
value_ptr arg;
{
register int len = TYPE_LENGTH (VALUE_ENCLOSING_TYPE (arg));
register int container_len = len;
register int offset;
and then run callfuncs and type "p t_float_values(float_val1,float_val2)",
I see that `len' gets the value of 8. So it seems like GDB already
knows that these arguments need to be passed as doubles.
Is it possible that GDB passes the float values as doubles, at least
on some platforms? What value does `len' have on the Solaris and
Unixware?