This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Re: RFA: remove target_memory_bfdsection and assorted cruft.
- To: jtc at redback dot com (J.T. Conklin)
- Subject: Re: RFA: remove target_memory_bfdsection and assorted cruft.
- From: David Taylor <taylor at cygnus dot com>
- Date: Fri, 19 May 2000 13:16:26 -0400
- cc: gdb-patches at sourceware dot cygnus dot com
From: jtc@redback.com (J.T. Conklin)
Date: 18 May 2000 19:17:50 -0700
I submit the enclosed changes for approval.
This removes the global variable target_memory_bfd_section which was
set in target_xfer_memory() but never used (except in long dead #if'd
out code). This allowed me to remove the section argument to target_
xfer_memory(), which allowed me to remove target_read_memory_section,
which allowed me to remove even more stuff.
This was discussed in on the gdb mailing list in a thread starting:
http://sourceware.cygnus.com/ml/gdb/2000-q1/msg00749.html
In that thread, I got approval in principal for these changes. Now I'm
seeking approval for the changes themselves.
--jtc
2000-05-18 J.T. Conklin <jtc@redback.com>
* target.h (target_memory_bfd_section): Removed declaration.
* target.c (target_memory_bfd_section): Removed.
* exec.c (xfer_memory): Removed #if'ed-out code which referenced
target_memory_bfd_section.
* target.h (target_read_memory_section): Removed declaration.
* target.c (target_read_memory_section): Removed.
(target_xfer_memory): Update, removed bfd_section argument.
(target_read_string, target_read_memory, target_write_memory):
Update for above change.
* gdbcore.h (read_memory_section): Removed declaration.
* corefile.c (read_memory_section): Removed.
* jv-lang.c (get_java_utf8_name): Changed calls to
read_memory_section to read_memory.
* printcmd.c (printf_command): Likewise.
* valops.c (value_at, value_fetch_lazy): Likewise.
The changes to jv-lang.c, printcmd.c, and valops.c (are trivial and) are
approved.