This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: GDB 5.0 won't build on GNU/Linux/sparc


Alexandre Oliva wrote:
> 
> On May 20, 2000, Alexandre Oliva <aoliva@cygnus.com> wrote:
> 
> >       * infrun.c (resume): Do not change continue to step if we single
> >       step on software.
> 
> > Index: gdb/infrun.c
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/infrun.c,v
> > retrieving revision 1.6.2.2
> > diff -u -r1.6.2.2 infrun.c
> > --- gdb/infrun.c      2000/04/20 11:00:29     1.6.2.2
> > +++ gdb/infrun.c      2000/05/20 09:39:27
> > @@ -902,7 +902,7 @@
> >           }
> >         else
> >           {
> > -           if (!step)
> > +           if (!SOFTWARE_SINGLE_STEP_P && !step)
> >               {
> >                 warning ("Internal error, changing continue to step.");
> >                 remove_breakpoints ();
> 
> I'm not sure I understood the final decision regarding this patch.
> Should I check it in or not?

No.  I'm not comfortable with it.  I would like to know why
sunos/sparc and solaris/sparc etc. never needed this change.
It seems to me that other SOFTWARE_SINGLE_STEP_P targets must
have dealt with the situation differently, and probably 
linux/sparc needs to do whatever they were doing.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]