This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Re: Patch to build gdb-5.0 with readline-4.1
- To: andrew dot gaylard at bsw dot co dot za
- Subject: Re: Patch to build gdb-5.0 with readline-4.1
- From: Eli Zaretskii <eliz at delorie dot com>
- Date: Mon, 29 May 2000 03:38:30 -0400 (EDT)
- CC: gdb-patches at sourceware dot cygnus dot com, "Mark E." <snowball3 at bigfoot dot com>
- References: <39316D76.EAB1DAD8@bsw.co.za>
- Reply-to: Eli Zaretskii <eliz at is dot elta dot co dot il>
> Date: Sun, 28 May 2000 21:03:18 +0200
> From: Andrew Gaylard <andrew.gaylard@bsw.co.za>
>
> /* readline include files */
> +/* This is needed to prevent readline-4.1 (re-)defining it. */
> +#define savestring
> #include <readline/readline.h>
> #include <readline/history.h>
>
> #include <signal.h>
>
> -/* readline defines this. */
> +/* readline needed this. */
> #undef savestring
What's the story behind this savestring gork? Is it possible to take
care of the problem in a cleaner way?
> rl_completer_quote_characters = gdb_completer_quote_characters;
> rl_readline_name = "gdb";
> + rl_terminal_name=getenv("TERM");
What does readline do with rl_terminal_name? What if getenv returns a
NULL pointer? (Non-Unix ports of GDB are likely to have $TERM
undefined.)