This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH RFC] PARAMS elimination - phase 2


On May 30,  4:23pm, Kevin Buettner wrote:

> Below are changes representing phase 2 of the campaign to purge the use
> of PARAMS from the gdb sources.

This patch is retracted.

There were several objections, which can be summarized as follows:

  - PARAMS should not be removed from the testsuite.

  - There were several non-PARAMS reformatting changes.  (Though there
    was also disagreement about whether this was a good thing or a bad
    thing.)

  - There needs to be an automatic method for making most of the
    changes.  (So that the script may be applied to local source
    trees that may not have been sync'd in a while.)

  - In the cases where PARAMS removal and reformatting needs to be
    done by hand, these changes need to be done slowly, at the rate of
    one or two files a day.

As Andrew suggested, I will attempt to revise my script to handle
and preserve leading indentation.  This will avoid gratuitous
reformatting changes to non-PARAMS struct elements.  It'll also
provide folks with a mechanism for removing PARAMS locally.

Hopefully, there will only a be a small number of PARAMS occurrences
left after application of a second script.  These, I will do by hand,
at the rate of one or two files a day.  The patches will be small
enough to easily review in a matter of minutes.

Kevin

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]