This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Re: [PATCH RFA] TARGET_ADJUST_BREAKPOINT_ADDRESS...
- To: kevinb at cygnus dot com
- Subject: Re: [PATCH RFA] TARGET_ADJUST_BREAKPOINT_ADDRESS...
- From: Eli Zaretskii <eliz at delorie dot com>
- Date: Wed, 21 Jun 2000 03:05:46 -0400 (EDT)
- CC: gdb-patches at sourceware dot cygnus dot com
- References: <1000621031433.ZM31859@ocotillo.lan>
- Reply-to: Eli Zaretskii <eliz at is dot elta dot co dot il>
> Date: Tue, 20 Jun 2000 20:14:33 -0700
> From: Kevin Buettner <kevinb@cygnus.com>
>
> If a breakpoint address is adjusted, there's some new code in
> breakpoint.c which'll print out a warning. Such a warning might
> look something like this...
>
> (gdb) b foo
> warning: Breakpoint address moved from 0x06200090 to 0x0620008c.
> Breakpoint 1 at 0x0620008c: file bar.c, line 21.
Printing a message is a good idea, but making it a warning IMHO is
not. Warning is for some potential trouble, while in this case GDB is
doing The Right Thing. Printing a warning will confuse users.
Perhaps we should make the information about moving the breakpoint
part of the "Breakpoint 1 at ..." message.
My other comment is about hardware-assisted breakpoints: it looks
like, at least in some of the examples you gave, the address of
hardware-assisted breakpoints will also need to be adjusted in the
same way. So I think we need some provision for that as well.