This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

RFC: internal_error() change + abort()


Hello,

Now that we've moved to ISO-C we might as well make use of __LINE__ and
__FILE__.  With that in mind, I'd like to change internal_error()'s
signature to:

	internal_error (const char *file, long line,
			const char *fmt, ...);

with all files updated accordingly.

The second, kind of related change, is to just go through and purge all
but one call to abort() with a call to:

	internal_error (__FILE__, __LINE__, "FIXME: Code was calling abort()");

The abort() calls scattered through out GDB need to eventually be
converted to error() or internal_error() (case by case).  This, somewhat
brutal change, at least stops GDB dumping core on the poor user.

Comments?

	Andrew

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]