Re: RFA: Testsuite patches...

[Michael Snyder <msnyder at redhat dot com>]

Scott Bambrough wrote:
> 
> 2000-07-26  Scott Bambrough <scottb@netwinder.org>
> 
>         * linux-thread.c (linux_threads_pid_to_str):  Change "Pid" to
>         "process" to allow gdb.base/environ.exp to pass all tests.

I don't see any reference to the string "Pid" in environ.exp, 
and the references to "process" are not testing the output
that you changed.  Why do you want this change?

>         Change capitalization on "Thread" for consistency.

Consistency with what?  I'm not strongly opposed, but since
SOMEONE may depend on this output, I'd like to know the
motivation for changing it.

> 
> 2000-07-26  Scott Bambrough <scottb@netwinder.org>
> 
>         * gdb.base/environ.exp: Run tests for all targets.
>         * gdb.base/recurse.exp: Run tests for all targets.
> 
>         * gdb.base/sect-cmd.exp: Run tests for all targets.  Use
>         'section .text' clause for Linux in set section command
>         test.
> 
>         * gdb.base/so-impl-ld.exp: Added wildcard to
>         handle the gnu-oldld case on ARM.
> 
>         * gdb.base/so-indr-cl.exp: Run tests for *-*-linux-gnu*.
>         * gdb.base/watchpoint.exp (test_stepping): Clear xfail
>         for ARM targets.
> 
> I've had these tests in my tree for quite a while now.  Most were HP specific,
> but I believe they are generic enough for all platforms, or
> at least all Linux platforms.  I've tested them on Linux on ARM and x86.  I
> suggest we add them in and deal with failures on specific targets as they
> happen.  Comments?
> 
> BTW, I had to make the change to tweak to linux-thread.c to get environ.exp to
> run correctly.  I changed this rather than the pattern to match in the test for
> fear of breaking the test on HP platforms.
> 
> Scott
> 
> --
> Scott Bambrough - Software Engineer
> REBEL.COM    http://www.rebel.com
> NetWinder    http://www.netwinder.org
> 
>     ---------------------------------------------------------------
> 
>                   Name: gdbtest.patch
>    Part 1.2       Type: application/x-unknown-content-type-patch_auto_file
>               Encoding: base64