This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH RFC] Protoize cxux-nat.c, d10v-tdep.c, d30v-tdep.c
- To: Michael Elizabeth Chastain <chastain at cygnus dot com>
- Subject: Re: [PATCH RFC] Protoize cxux-nat.c, d10v-tdep.c, d30v-tdep.c
- From: Kevin Buettner <kevinb at cygnus dot com>
- Date: Wed, 9 Aug 2000 19:43:01 -0700
- Cc: gdb-patches at sourceware dot cygnus dot com
- References: <200008100202.TAA00817@train2.cygnus.com>
On Aug 9, 7:02pm, Michael Elizabeth Chastain wrote:
> I proofread it and found no errors.
Thanks again for proofreading my patches.
The only concern that I have about it is whether or not the comment on
`regno' for fetch_inferior_registers() should be preserved. The
comment "Original value discarded" didn't seem terribly useful to me,
so I got rid of it.
There were two other comments that were discarded as well, but both of
these were inaccurate (they say that the `fi' parameter is unused when
that is clearly not the case), so eliminating these comments seems
justified.