This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Problems with i386_register_convert_to_virtual


> Date: Tue, 08 Aug 2000 15:39:07 -0700
> From: Andrew Cagney <ac131313@cygnus.com>
> 
> Eli Zaretskii wrote:
> > 
> > > From: Robert Hoehne <robert.hoehne@gmx.net>
> > > Date: Sun, 6 Aug 2000 10:52:41 +0200
> > >
> > > After more searching in the GDB code and docs, I found the macro
> > > REGISTER_CONVERTIBLE which tells, if a register have different
> > > raw and virtual sizes. This macro is also used for instance in findvar.c
> > > to decide, if REGISTER_CONVERT_TO_VIRTUAL is called or a
> > > simple memcpy is done. In my Opionion either this should be documented
> > > in the description for REGISTER_CONVERT_TO_VIRTUAL that
> > > this macro should be called only, when REGISTER_CONVERTIBLE
> > > returns true, or that logic should be included in the convert macro.
> > 
> > I agree.  Does anyone have preferences as to what way of these two is
> > the best?
> 
> I'd suggest adjusting the documentation.

I committed a suitable change to gdbint.texinfo.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]