Re: 2nd try [PATCH RFA] Pascal language part 3: Changes to Makefile.in

[David Taylor <taylor at cygnus dot com>]

    From: Pierre Muller <muller@cerbere.u-strasbg.fr>
    Newsgroups: cygnus.patches.gdb
    Date: Thu, 17 Aug 2000 16:21:56 +0200

    Back after my holidays, I would like to resubmit 
    the following patch.

      This patch only covers the changes to Makefile.in
    needed to incoporate pascal specific files into GDB.

      MAINTAINERS files says ALL?
      Andrew Cagney said that he tested this and it worked nicely,
    but I whould like to have David Taylor's approval as this really concerns
    language support.

    The only differences to my first patch proposal are:
      - the addition to the file substitution list for djgpp 
    as requested by Eli Zaretskii.
      - added missing dependency of p-valprint.o on p-lang.h.

    ChangeLog entry:

    2000-08-17  Pierre Muller <muller@ics.u-strasbg.fr>
       * Makefile.in: add rules to compile and link pascal specific files.

I generally prefer context (-c) or unified (-u) diffs.  In a straight
diff, you often can't tell whether a change is okay or not; in this
case it was okay.

Approved.

       * config/djgpp/fnchange.lst: add substitution for p-exp.tab.c

Looks okay to me, but I defer to the djgpp maintainers.

    Index: Makefile.in
    ===================================================================
    RCS file: /cvs/src/src/gdb/Makefile.in,v
    retrieving revision 1.42
    diff -r1.42 Makefile.in
    491c491,492
    < 	mem-break.c minsyms.c mipsread.c nlmread.c objfiles.c parse.c \
    ---
    > 	mem-break.c minsyms.c mipsread.c nlmread.c objfiles.c \
    > 	p-exp.y p-lang.c p-typeprint.c p-valprint.c parse.c \
    583c584
    < 	m2-lang.h \
    ---
    > 	m2-lang.h  p-lang.h \
    637c638
    < 	m2-lang.o \
    ---
    >  	m2-lang.o p-lang.o p-typeprint.o p-valprint.o \
    657c658
    < 	f-exp.tab.c m2-exp.tab.c
    ---
    > 	f-exp.tab.c m2-exp.tab.c p-exp.tab.c
    660c661
    < 	f-exp.tab.o m2-exp.tab.o
    ---
    > 	f-exp.tab.o m2-exp.tab.o p-exp.tab.o
    807a809
    > 	#unload $(srcdir)/p-exp.y
    812a815
    > 	#load p-exp.tab.c
    905c908
    < 		f-exp.tab.c m2-exp.tab.c
    ---
    > 		f-exp.tab.c m2-exp.tab.c p-exp.tab.c
    1038a1042,1059
    > # p-exp.tab.c is generated in objdir from p-exp.y if it doesn't exist
    > # in srcdir, then compiled in objdir to p-exp.tab.o.
    > # Remove bogus decls for malloc/realloc/free which conflict with everything
    > # else.
    > p-exp.tab.o: p-exp.tab.c
    > p-exp.tab.c: p-exp.y
    > 	$(SHELL) $(YLWRAP) "$(YACC)" $(srcdir)/p-exp.y  y.tab.c p-exp.tmp --
    $(YFLAGS)
    > 	-sed -e '/extern.*malloc/d' \
    > 	     -e '/extern.*realloc/d' \
    > 	     -e '/extern.*free/d' \
    > 	     -e '/include.*malloc.h/d' \
    > 	     -e 's/malloc/xmalloc/g' \
    > 	     -e 's/realloc/xrealloc/g' \
    > 	     -e '/^#line.*y.tab.c/d' \
    > 	  < p-exp.tmp > p-exp.new
    > 	-rm p-exp.tmp
    > 	mv p-exp.new ./p-exp.tab.c
    > 
    1041c1062
    < .PRECIOUS: jv-exp.tab.c
    ---
    > .PRECIOUS: jv-exp.tab.c p-exp.tab.c
    1512a1534,1543
    > p-lang.o: p-lang.c p-lang.h $(defs_h) $(expression_h) $(gdbtypes_h) \
    > 	language.h parser-defs.h $(symtab_h) gdb_string.h
    > 
    > p-typeprint.o: p-typeprint.c p-lang.h $(defs_h) $(expression_h) \
    > 	$(gdbcmd_h) $(gdbcore_h) $(gdbtypes_h) language.h $(symtab_h) \
    > 	target.h typeprint.h $(value_h) gdb_string.h
    > 
    > p-valprint.o: p-valprint.c p-lang.h $(defs_h) $(expression_h)
    $(gdbtypes_h) \
    > 	language.h $(symtab_h) valprint.h $(value_h) gdb_string.h
    > 
    1956a1988,1991
    > 	$(bfd_h) objfiles.h symfile.h
    > 
    > p-exp.tab.o: p-exp.tab.c $(defs_h) $(expression_h) $(gdbtypes_h) \
    > 	language.h p-lang.h parser-defs.h $(symtab_h) $(value_h) \
    Index: config/djgpp/fnchange.lst
    ===================================================================
    RCS file: /cvs/src/src/gdb/config/djgpp/fnchange.lst,v
    retrieving revision 1.7
    diff -r1.7 fnchange.lst
    138a139
    > @V@/gdb/p-exp.tab.c @V@/gdb/p-exp_tab.c 


    Pierre Muller
    Institut Charles Sadron
    6,rue Boussingault
    F 67083 STRASBOURG CEDEX (France)
    mailto:muller@ics.u-strasbg.fr
    Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99