Re: core dump support for cygwin

[Chris Faylor <cgf at cygnus dot com>]

On Fri, Aug 25, 2000 at 12:12:43PM +0400, Egor Duda wrote:
>Friday, 25 August, 2000 Chris Faylor cgf@cygnus.com wrote:
>CF> I have a couple of very minor nits.
>
>CF> It looks like you should be defining O_BINARY similarly to the way that it's
>CF> done in exec.c.  Otherwise systems which don't support this open flag will have
>CF> problems.
>
>CF> (I wonder if this should actually be defined in defs.h or something since it is used
>CF> all over the place in gdb)
>
>CF> Your changes to win32-nat.c use both K&R function definitions and ANSI prototypes.
>CF> Please just use the modern usages for all of your function definitions.
>
>CF> I'd prefer if you renamed cygwin_solib_add to child_solib_add to make this consistent
>CF> with the rest of the function names in the file.
>
>done.
>
>Egor.            mailto:deo@logos-m.ru ICQ 5165414 FidoNet 2:5020/496.19

Applied.  I tweaked your ChangeLog entry a little to eliminate duplicate file name
references and maintain "present tense".

I haven't tried the core dump facility yet, since I need to play with my Cygwin
setup a little to do that but gdb seems to work fine in normal mode.

Thanks again for this contribution.  It's much appreciated.

cgf