This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFD: Testsuite cases for inferior function calls
- To: "Peter.Schauer" <Peter dot Schauer at regent dot e-technik dot tu-muenchen dot de>
- Subject: Re: RFD: Testsuite cases for inferior function calls
- From: Fernando Nasser <fnasser at cygnus dot com>
- Date: Mon, 18 Sep 2000 16:49:29 -0400
- CC: Orjan Friberg <orjan dot friberg at axis dot com>, gdb-patches at sourceware dot cygnus dot com
- Organization: Red Hat , Inc. - Toronto
- References: <200009182021.WAA26338@reisser.regent.e-technik.tu-muenchen.de>
"Peter.Schauer" wrote:
>
> This seems to be a flaw with generic_push_dummy_frame, and I currently have
> no idea how to fix it as well.
>
> >From a user perspective (User doesn't care where the breakpoint was hit, and
> finish should work as expected), I'd say that this is a FAIL and should
> stay a FAIL till it gets fixed (probably saying `known problem with...').
>
> As the usage of XFAILs throughout the testsuite increased during the last
> two years, you might as well XFAIL the test on the affected targets.
>
OK, suppose we xfail it for all targets except the ones you've already verified?
We still get the other targets tested and it will either show as a XFAIL or a
XPASS (if we are that lucky). No FAILs will be added and, with the *known problem*
comment added we can check it in as a start point for some improvements on this area.
Sounds reasonable?
P.S.: I believe there is still one maintainer that have not answered regarding to one
of the bug fixes in your patch. You should wait to check at least these fixes in with
it. Maybe ping the maintainer directly in case he missed the posting thinking it was
only a testsuite patch and not related to the specific target.
--
Fernando Nasser
Red Hat - Toronto E-Mail: fnasser@cygnus.com
2323 Yonge Street, Suite #300 Tel: 416-482-2661 ext. 311
Toronto, Ontario M4P 2C9 Fax: 416-482-6299