Re: New s390 gdb patch

[DJBARROW at de dot ibm dot com]

Thanks for your response,

I'll check out again in the next few days once I've other work out of the
way.

Martin already has submitted patches against bfd so I'll put the binutils
into a separate patch as gdb binutils
is not the same as the latest binutils.

The check for link_map_32 was completely wrong for starters there is no
file called sys/link.h on aix or linux
& the test didn't even compile thus gcc returned a non zero error code not
the actual code snippet which was supposed to be
run therfore HAVE_LINK_MAP_32 was defined in config.h

The sigcontext.h & s390-gdbregs-common.h etc are directly from linux & I
purposely did the code this way
to ease maintainence.

I think Boas will be filling out a release form for 2 a two line fix to a
configure file in readline :-).

I'll do my best with the rest of your suggestions.

D.J. Barrow Linux for S/390 kernel developer
eMail: djbarrow@de.ibm.com,barrow_dj@yahoo.com
Phone: +49-(0)7031-16-2583
IBM Germany Lab, Schönaicherstr. 220, 71032 Böblingen


Andrew Cagney <ac131313@cygnus.com> on 29.09.2000 02:44:14

Please respond to Andrew Cagney <ac131313@cygnus.com>

To:   Denis Joseph Barrow/Germany/Contr/IBM@IBMDE
cc:   Boas Betzler/Germany/IBM@IBMDE, Gregory Burke/Poughkeepsie/IBM@IBMUS,
      gdb-patches@sourceware.cygnus.com, Michael Snyder
      <msnyder@redhat.com>, Martin Schwidefsky/Germany/IBM@IBMDE, Binutils
      Patches <binutils@sourceware.cygnus.com>
Subject:  Re: New s390 gdb patch




I'd suggest having a look through the files src/MAINTAINERS and
src/gdb/CONTRIBUTE.

The patches to */bfd need to be sent to binutils@sources.redhat.com for
approval.  I'm not the binutils maintainer.

The patch to config.sub need to be submitted to the config maintainer.
Contact details are on http://www.gnu.org.

The patch contains ChangeLog entries as a diff.  Please do not do that,
please separate out those entries and please format them consitent with
other ChangeLog entries.

The change to gdb/config.in replaces one test for link_map32 with
another different test.  It needs to be written in a way such that both
the old and the new test work.

The changes to opcodes/* need to be sent to the binutils mailing list
for approval.

The changes to readline/* need to be sent to the readline maintainer.
Only once approved there will I accept them.

GDB no longer accepts new contributions that contain PARAMS or K&R c.

GDB no longer accepts new targets that do not use the new multi-arch
framework.  See the m68hc11 target.

Many of the C files don't comply with the gnu coding standard.  I'd
suggest running the code through GNU indent.

The copyright notices will need to be updated :-)

--

Rather than let this dangle, and given the legal hoops it sounds like
you are going through, I'd like to propose that a branch be created and
your patches, as submitted, be applied to that.  It will then be
possible to work through all the issues and get the changes merged into
trunk.

If this was done, would it be reasonable to assume that your assignment
would allow you to submit changes (without further legal hoops) to the
public repository.  (Better ask that lawyer?)

The alternative, unfortunatly, is to break down the patches into BFD and
GDB parts, resolve each of the issues, and then submit the patches and
paper work.

     again sorry,
          Andrew