Re: RFA: Patch ser-unix.c to only call ui hook when target running (WITHDRAW)

[Fernando Nasser <fnasser at cygnus dot com>]

Steven Johnson wrote:
> 
> I assume you were talking about me in this post.
> 
> Fernando Nasser wrote:
> >
> >
> > I am working on that fix but I will have to ask someone who has an environment that can
> > reproduce one of the bugs to test it (I do not have the necessary setup to reproduce it
> > here).  I wonder if we shouldn't add it as a temporary fix until the other patch is
> > ready so people do not download a broken Insight.  I would add a FIXME comment line to
> > the patch below and make a patch replacing this with the other (more elegant) fix when
> > it is ready.
> >
> 
> Testing it is no problem, let me know what you want me to do when you are
> ready.
> 

Thanks Steven.  I couldn't do it today (or anything else) as I am preparing something
for a meeting.  I will do it tomorrow though.


> As for the patch being temporarily applied, It really only seemed to affect me
> so I wouldn't bother at this point (I already have my fix locally). I am
> monitoring the list, as you are, so if anyone posts about the problem we can
> send them a temporary patch to get around it. I can't see this taking too long
> to fix properly anyway (relatively speaking) so there seems little point in
> doing it twice.
> 

The bad news is that this particular part of the fix (the ser-unix.c part) also causes
another symptom (try holding the enter button on the Memory Window address entry box
and look at an open Console Window).  It prints weird messages and eventually dumps core.

That problem was reported through another channel (that is why it did not appear on
the list) and I only figured the association when we were both working on the fix for your
problem (which also requires patching the Tcl code).

Anyway, I will try to cook something tomorrow and test with the Memory Window.
To be absolutely sure, I will take you on your offer and ask you to try it with your
setup as well.

Thanks again for all the help.


-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@cygnus.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9