This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

[PATCH RFC] Protoize symtab.c, thread.c


More protoization...

Reviewers will want to look at the thread_callback_func typedef in
gdbthread.h when reviewing iterate_over_threads().  (I added in the
argument types for the callback function.)

	* symtab.c (decode_line_2, file_matches, search_symbols): Protoize.
	* thread.c (iterate_over_threads): Protoize.

Index: symtab.c
===================================================================
RCS file: /cvs/src/src/gdb/symtab.c,v
retrieving revision 1.17
diff -u -r1.17 symtab.c
--- symtab.c	2000/10/12 19:34:27	1.17
+++ symtab.c	2000/10/27 01:31:22
@@ -3260,11 +3260,8 @@
    as canonical line specs there.  */
 
 static struct symtabs_and_lines
-decode_line_2 (sym_arr, nelts, funfirstline, canonical)
-     struct symbol *sym_arr[];
-     int nelts;
-     int funfirstline;
-     char ***canonical;
+decode_line_2 (struct symbol *sym_arr[], int nelts, int funfirstline,
+	       char ***canonical)
 {
   struct symtabs_and_lines values, return_values;
   char *args, *arg1;
@@ -3479,10 +3476,7 @@
 }
 
 static int
-file_matches (file, files, nfiles)
-     char *file;
-     char *files[];
-     int nfiles;
+file_matches (char *file, char *files[], int nfiles)
 {
   int i;
 
@@ -3539,12 +3533,8 @@
    free_search_symbols should be called when *MATCHES is no longer needed.
  */
 void
-search_symbols (regexp, kind, nfiles, files, matches)
-     char *regexp;
-     namespace_enum kind;
-     int nfiles;
-     char *files[];
-     struct symbol_search **matches;
+search_symbols (char *regexp, namespace_enum kind, int nfiles, char *files[],
+		struct symbol_search **matches)
 
 {
   register struct symtab *s;
Index: thread.c
===================================================================
RCS file: /cvs/src/src/gdb/thread.c,v
retrieving revision 1.6
diff -u -r1.6 thread.c
--- thread.c	2000/07/30 01:48:27	1.6
+++ thread.c	2000/10/27 01:31:22
@@ -191,9 +191,8 @@
  */
 
 struct thread_info *
-iterate_over_threads (callback, data)
-     int (*callback) ();
-     void *data;
+iterate_over_threads (int (*callback) (struct thread_info *, void *),
+		      void *data)
 {
   struct thread_info *tp;
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]