This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

symtab.h: 2000-10-12 SYMBOL_INIT_DEMANGLED_NAME change, why ?


I do not understand the need for the following change:

2000-10-12  Elena Zannoni  <ezannoni@kwikemart.cygnus.com>

	From Daniel Berlin <dberlin@redhat.com> :

	* symtab.h (SYMBOL_INIT_DEMANGLED_NAME): Initialize the symbol
 	language to auto instead of unknown, so it will try to demangle
 	the symbol.

Dan, could you provide an example why this is needed ?

Minimal symbols are always demangled with language_auto.
Symbol readers make sure that the proper language is used for
SYMBOL_INIT_DEMANGLED_NAME, either via cu_language or via
deduce_language_from_filename.

So language_unknown should not happen normally, it looks to me like this
change is trying to cure a symptom rather than a cause.

And if we really should need this change, the comment for
SYMBOL_INIT_DEMANGLED_NAME should be updated, currently it no longer reflects
reality.

-- 
Peter Schauer			pes@regent.e-technik.tu-muenchen.de

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]