Re: [RFA] 100494 fix

[Larry Smith <larry at smith-house dot org>]

Fernando Nasser wrote:
> 
> Good catch Larry.  But please add a labeled frame around the radiobuttons,
> will you?  The target selection dialog expansion box does look weird with
> two square buttons and two rounds with no explanation.
> 
> "Run method" sounds right for the frame label.
> 
> If you really want to fix this, make sure the option is set to "run" and
> the buttons greyed if the target "exec" is selected.


Okay, this is a bit more involved than the previous patch,
but it seems to do what Fernando wants.  It adds a new var
to the header file to save the pathnames for the run method
buttons, and when the target selection is changed to "exec",
these buttons are greyed out (and "run" selected) and when
it is anything else, the buttons are active and set to what-
ever the program would have set them to.

This has NOT been checked in or committed.  Permission to
do so?

> cvs diff -r 1.2 targetselection.ith
Index: targetselection.ith
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.ith,v
retrieving revision 1.2
diff -r1.2 targetselection.ith
57a58,59
> 
>     variable run_method
> 


> cvs diff -r 1.5 targetselection.itb
Index: targetselection.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.itb,v
retrieving revision 1.5
diff -r1.5 targetselection.itb
489a490,493
>   set rm_frame [iwidgets::labeledframe $frame.run_method -labelpos nw -labeltext "Run Method" ]
>   set run_method [ $rm_frame childsite ]
> 
>   set rm_label [label $frame.label -text "Run Method:"]
491c495
<   radiobutton $frame.cont -text {Continue from Last Stop} -value 1
-variable $var \
---
>   radiobutton $run_method.cont -text {Continue from Last Stop} -value 1 -variable $var \
495c499
<   radiobutton $frame.run -text {Run Program} -value 1 -variable $var \
---
>   radiobutton $run_method.run -text {Run Program} -value 1 -variable $var \
501,504c505,516
<   grid $frame.attach $frame.run -sticky w
<   grid $frame.load   $frame.cont -sticky w
<   grid $frame.afterl -sticky we -columnspan 2
<   grid $frame.aftere -sticky we -columnspan 2
---
> 
>   grid $frame.label -column 1 -row 0 -sticky w
>   grid $frame.attach -column 0 -row 1 -ipady 2
>   grid $frame.load -column 0 -row 2 -ipady 2
> 
>   grid $run_method.run -column 0 -row 1 -sticky w -ipady 2
>   grid $run_method.cont -column 0 -row 2 -sticky w -ipady 2
>   
>   grid $rm_frame -column 1 -row 1 -rowspan 2 -sticky nsew -ipady 2
> 
>   grid $frame.afterl -row 4 -sticky we -columnspan 2 -ipady 2
>   grid $frame.aftere -sticky we -columnspan 2 -ipady 2
724a737,745
> 
>   if { "$target" == "exec" } {
>     $run_method.run configure -state disabled -value 1
>     $run_method.cont configure -state disabled
>   } else {
>     $run_method.run configure -state normal
>     $run_method.cont configure -state normal
>   }
> 
> 




> 
> Cheers,
> Fernando
> 
> P.S.: Insight patches go to the insight list, not gdb-patches as the people
> that wrote the code watch it more closely and there is a larger group of
> users and contributors in this list that do not subscribe to gdb-patches.
> 
> Larry Smith wrote:
> >
> > The following patch is for 100494, changing a pair of checkbuttons
> > to radiobuttons.  Since the proper behaviour was already enforced
> > this is really only cosmetic, and changes no current control flow.
> >
> > I apologise for being unaware of proper protocol for doing patches
> > on sourceware, this has already been checked in.  I will try to be
> > more circumspect in the future...
> >
> > regards,
> > Larry
> >
> > 2000-10-26  Larry Smith  <lsmith@redhat.com>
> >
> >         * change targetselection.itb: Run Program and Continue From Last Stop
> >         are now radio buttons rather than checkbuttons
> >
> > Index: targetselection.itb
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.itb,v
> > retrieving revision 1.4
> > retrieving revision 1.5
> > diff -u -r1.4 -r1.5
> > --- targetselection.itb 2000/09/12 20:04:11     1.4
> > +++ targetselection.itb 2000/10/26 20:47:57     1.5
> > @@ -488,11 +488,11 @@
> >    checkbutton $frame.load -text {Download Program} -variable $var
> >
> >    set var [pref varname gdb/src/run_cont]
> > -  checkbutton $frame.cont -text {Continue from Last Stop} -variable $var \
> > +  radiobutton $frame.cont -text {Continue from Last Stop} -value 1 -variable $var \
> >      -command [code $this set_run run]
> >
> >    set var [pref varname gdb/src/run_run]
> > -  checkbutton $frame.run -text {Run Program} -variable $var \
> > +  radiobutton $frame.run -text {Run Program} -value 1 -variable $var \
> >      -command [code $this set_run cont]
> >
> >    # The after attaching command entry
> 
> --
> Fernando Nasser
> Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
> 2323 Yonge Street, Suite #300
> Toronto, Ontario   M4P 2C9

-- 
 .-.    .-. .---. .---. .-..-. | "Bill Gates is just a monocle
 | |__ / | \| |-< | |-<  >  /  | and a Persian Cat away from
 `----'`-^-'`-'`-'`-'`-' `-'   | being one of the bad guys in a
       My opinions only.       | James Bond movie." -- D Miller