This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: minsyms.c bug: broken hashtables after doing msymbols_sort()


On Nov 6,  7:37pm, Till Straumann wrote:

> There is a bug in minsyms.c. When re-sorting the msymbols[]
> array
> in an objfile, the hashtables which hold pointers to
> the
>  msymbols[] entries become invalid. Therefore, the hash
> tables must be recreated after sorting. A patch is attached 
> (against gdb-5.0).

Right you are.  But, I believe this bug has already been fixed by:

2000-08-04  Kevin Buettner  <kevinb@redhat.com>

	* minsyms.c (build_minimal_symbol_hash_tables): New function.
	(compact_minimal_symbols): Don't construct hash tables here.
	(install_minimal_symbols): Instead, construct them here.
	(msymbols_sort): And rebuild them here too.

See also my original email on the matter:

    http://sources.redhat.com/ml/gdb-patches/2000-08/msg00082.html

Thanks,

Kevin

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]