This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: Split linespec from symtab
Fernando Nasser writes:
> Elena Zannoni wrote:
> >
> > Fernando, this is OK with me.
> > 2 things though:
> >
> > 1. Who's going to maintain this file?
> > I am asking because there are some patches pending from Dan, and I
> > don't want those to fall through the cracks. Maybe I can be a
> > co-maintainer?
> >
>
> I believe this is an interface between GDB's symbolic services and the
> interpreters (both command line and GUI) which use it.
>
> If Andrew does not object, I believe the maintainers of symtab.c (Jim and Elena)
> should be responsible for this file with perhaps the addition of myself as a
> CLI/GUI representative.
Ok with me.
>
> > 2. Some C++ specific functions will be moved to linespec.c to which they
> > don't really belong, just as they didn't belong to symtab.c.
> > So at some stage the c++ functions may be further separated, into
> > their own files. But this is not a problem, I would think. Maybe
> > add a comment to that effect in linespec.c.
> >
>
> Good move. I had noticed that and I agree with it (I even mentioned one of these
> functions in my submission).
>
> But I rather add the comments afterwards so this patch shows just the
> unchanged movement of code, for documentation purposes.
> We add the FIXMEs in a separate commit. Is that OK?
>
Yep. Go ahead.
Elena